LucasGGamerM / moshidon

Better modification of the official Mastodon for Android app
https://LucasGGamerM.github.io/moshidon/
GNU General Public License v3.0
612 stars 29 forks source link

weird translation and grammar #225

Open waitingmoon opened 1 year ago

waitingmoon commented 1 year ago

As a Japanese speaker, I found some strange behavior. According to the translation file, In the expected behavior, the client name part should be written as "2023年7月7日 12:17にWeb経由", but actually it is written as "2023年7月7日12:17に経由Web".

<string name="timestamp_via_app">%1$sに%2$s経由</string> https://github.com/LucasGGamerM/moshidon/blame/e9ed82d471bff380e70c43653a921ab15c882a46/mastodon/src/main/res/values-ja-rJP/strings.xml#L318

Screenshot_20230707-122929~(1)

LucasGGamerM commented 1 year ago

So I believe this is an issue with the official mastodon translate crowdin, and as such, you should go over there to fix it. https://crowdin.com/project/mastodon-for-android

waitingmoon commented 1 year ago

Someone had already fixed it. https://crowdin.com/translate/mastodon-for-android/124/en-ja?filter=basic&value=0#12334

Also I edited strings.xml and rebuilt the app and got the following results:

<string name="timestamp_via_app">%1$s via %2$s</string> via

<string name="timestamp_via_app">%1$s に %2$s から投稿</string> karatoukou

<string name="timestamp_via_app">%1$s に次から投稿 %2$s</string> tsugikara

LucasGGamerM commented 1 year ago

Is it fixed? We have merged all translations from the mastodon crowdin, so its up to you to see if its alright again (I don't know japanese sadly)