LucasGGamerM / moshidon

Better modification of the official Mastodon for Android app
https://LucasGGamerM.github.io/moshidon/
GNU General Public License v3.0
472 stars 23 forks source link

not getting notification #341

Open kvnco opened 4 months ago

kvnco commented 4 months ago

Describe the bug

I am not receiving any notification

To reproduce

Moshidon installed All notifications enabled, not snoozed Not using notifiedPush Notifications are allowed for the app on Android

Looks similar to bug report #337 except I'm not using a degoogled OS

Does this happen in the official app?

Does this issue also occur with the respective upstream release? Not tested

Screenshots and screen recordings

image

Version

Moshidon v2.1.4+fork.104.moshinda installed from FDroid repo on Android 13

Crash log

N/A

LucasGGamerM commented 4 months ago

At the present moment, you have to enable unified push to receive notifications on a degoogled os. I am working on polling notifications for the next release though

kvnco commented 4 months ago

I'm NOT using a degoogled os, then notifiedPush isn't required, is it?

LucasGGamerM commented 4 months ago

Ohh, okay. I misread the 'not' over there 😅

In any case, try logging out and logging back in. Sometimes the registration for push notifications goes wrong, and that usually fixes it

kvnco commented 4 months ago

No problem!

You are suggesting, from the app to logout from the Mastodon account and login again? OKay, I'll try and let you know!

kvnco commented 4 months ago

I did it and the issue is still here. Maybe I did not understood correctly what I had to do?

LucasGGamerM commented 4 months ago

Hmmm, that is indeed weird. What instance are you on? Maybe they are having a problem with registering for push notifications. In any case, wiping the data of the app is also a thing you could try.

kvnco commented 4 months ago

I'm using framapiaf.org I have no issue with Tusky

Will try wiping data

kvnco commented 4 months ago

Just to be clear (in case of...): when I open Moshidon, I can see the notif in the "Notifications" tab but I do not see any notification in the Android notification drawer

FineFindus commented 4 months ago

Moshidon v2.1.4+fork.104.moshinda installed from FDroid repo on Android 13

The F-Droid version only supports Unified Push, since FCM (the default notification method) requires a connection to Googles proprietary servers.

kvnco commented 4 months ago

Thank you for your answer, it makes sense.

Then I'm assuming that it's a choice made on purpose to avoid relying on Google Play services or similar lib to allow compatibility with degoogled os? If I'm correct it's fair, but then it may be a good idea to explicitly mention it as a warning or limitation on the description of the app!

p1gp1g commented 4 months ago

Moshidon v2.1.4+fork.104.moshinda installed from FDroid repo on Android 13

The F-Droid version only supports Unified Push, since FCM (the default notification method) requires a connection to Googles proprietary servers.

Mastodon (Android) and its forks does not use firebase-messaging and its proprietary blobs to get FCM notifications, so it should work.

It uses: https://github.com/LucasGGamerM/moshidon/blob/a1a4c59b8363b88f6ba82fa7085172e0b2ca48e5/mastodon/src/main/java/org/joinmastodon/android/PushNotificationReceiver.java and it is included in F-Droid build :)

@kvnco can you try to log out and login again on moshidon ?

kvnco commented 4 months ago

Already did earlier today without success: https://github.com/LucasGGamerM/moshidon/issues/341#issuecomment-1932260276

FineFindus commented 4 months ago

It uses: https://github.com/LucasGGamerM/moshidon/blob/a1a4c59b8363b88f6ba82fa7085172e0b2ca48e5/mastodon/src/main/java/org/joinmastodon/android/PushNotificationReceiver.java and it is included in F-Droid build :)

FCM registration is disabled for F-Droid builds, due to the NonFreeNet antifeature (see https://github.com/LucasGGamerM/moshidon/issues/206 for more context).

https://github.com/LucasGGamerM/moshidon/blob/a1a4c59b8363b88f6ba82fa7085172e0b2ca48e5/mastodon/src/main/java/org/joinmastodon/android/api/PushSubscriptionManager.java#L124-L131

p1gp1g commented 4 months ago

Well, I missed that point, sorry :)

LucasGGamerM commented 4 months ago

Well, I missed that point, sorry :)

I forgot it too, so don't worry :D

pslyman commented 1 month ago

I also have not been getting notifications, even after clean install and login.

LucasGGamerM commented 1 month ago

Did you install it from fdroid? If so, you need a unifiedPush provider to have notifications

Mannivu commented 1 month ago

Ah, that explain why. On the app there's no alert about this, though.

FineFindus commented 1 month ago

There will be in the next version.

pslyman commented 1 month ago

Did you install it from fdroid? If so, you need a unifiedPush provider to have notifications

Indeed I did. Thanks for explaining.

CeruleanDerpo commented 2 weeks ago

notifications are not working for me even with ntfy installed