search

LucasLeandro1204 / Pornsearch

Easy way to search for porn content!
MIT License
329 stars 68 forks source link

Change module loading #8

Closed LucasLeandro1204 closed 6 years ago

LucasLeandro1204 commented 6 years ago

Currently I'm doing this way: https://github.com/LucasLeandro1204/Pornsearch/blob/master/src/Pornsearch.js#L78

But It's never gonna work in browser, so we have to require every module instead of searching for them. It will be easy xd

marcelorl commented 6 years ago

Im taking this one.

marcelorl commented 6 years ago

Have a look:

https://github.com/LucasLeandro1204/Pornsearch/pull/10

LucasLeandro1204 commented 6 years ago

@marcelorl You can close this pr now then recreate after October 1, because if I merge it now it will not count to promo, but thank you xd

marcelorl commented 6 years ago

really???

Actually, I dont care.

You can merge it if you want.

You may open other issues to add tests...what do you think? Then I add them after october 1st.

LucasLeandro1204 commented 6 years ago

@marcelorl I was about to do that hahaha, ok so I will merge it now xd

marcelorl commented 6 years ago

awesome. thank you bro.