LucasPilla / Sorting-Algorithms-Visualizer

Program made with Python and Pygame module for visualizing sorting algorithms
MIT License
426 stars 164 forks source link

Add some docstrings / comments explainning each sorting algorithm #164

Closed LucasPilla closed 1 year ago

LucasPilla commented 1 year ago

Please, choose an avaiable algorithm and comment it's name before you start working.

Algorithms:

lucasrafaldini commented 1 year ago

Hey, I want to contribute with binaryinsertionSort docstrings.

lucasrafaldini commented 1 year ago

I took the liberty to also make the docstrings for bitonicSort. Here's the PR -> https://github.com/LucasPilla/Sorting-Algorithms-Visualizer/pull/165

lucasrafaldini commented 1 year ago

Hey guys.

I took advantage of the holidays in Brazil and wrote docstrings for all algorithms. I hope it helps. I tried to keep a certain "standard" but sometimes I didn't know everything about it or just didn't know anything to write about but I think they are a good starting point.

LucasPilla commented 1 year ago

@lucasrafaldini I will have a look asap, thanks! 😄

Velin-Todorov commented 1 year ago

Hi. Is this issue still open? Are there algorithms that still need comments/docstrings?

LucasPilla commented 1 year ago

@Velin-Todorov, @lucasrafaldini did a great job :wave: but there are some tasks to be done:

What do you think?

Velin-Todorov commented 1 year ago

It sounds great. Please assign this to me. Where can i find the docstrings?

Also, could you please provide me with a deadline?

Kind regards,

Velin

LucasPilla commented 1 year ago

@Velin-Todorov I just merged the pull request made by @lucasrafaldini.

raghavaraghav3 commented 1 year ago

@Velin-Todorov, @lucasrafaldini did a great job 👋 but there are some tasks to be done:

  • maybe it is better if we keep the docstrings 1 or 2 paragraphs long.
  • add a simple table with time and space complexity for each algorithm.
  • remove the "Args" and "Yields" parts, they are not useful at all

What do you think?

Hey @LucasPilla can you also assign this to me?? I can work on some of the algorithms.

Thanks, Ven

Velin-Todorov commented 1 year ago

@Velin-Todorov, @lucasrafaldini did a great job 👋 but there are some tasks to be done:

  • maybe it is better if we keep the docstrings 1 or 2 paragraphs long.
  • add a simple table with time and space complexity for each algorithm.
  • remove the "Args" and "Yields" parts, they are not useful at all

What do you think?

Hey @LucasPilla can you also assign this to me?? I can work on some of the algorithms.

Thanks, Ven

@Velin-Todorov, @lucasrafaldini did a great job 👋 but there are some tasks to be done:

  • maybe it is better if we keep the docstrings 1 or 2 paragraphs long.
  • add a simple table with time and space complexity for each algorithm.
  • remove the "Args" and "Yields" parts, they are not useful at all

What do you think?

Hey @LucasPilla can you also assign this to me?? I can work on some of the algorithms.

Thanks, Ven

Hi Ven. I prefer to work this task alone.

Kind regards,

Velin

Velin-Todorov commented 1 year ago

@LucasPilla I have finished editing the docstrings. Let me know what you think. Tomorrow I will add the table with the complexities as well.

Alex-Wengg commented 1 year ago

Hey @ Velin-Todorov, are any contributions left for this issue?

brkuhgk commented 1 year ago

@Velin-Todorov can you highlight the sorting algorithms which are not contributed.