Review 1

[yangdavid1985]

Design/Code Review 1

Project: Vagante Website

Developer: Lucas Tolly

Reviewer: David Yang

Category	Criteria	Rating/Comments
Problem Statement	Does it exist?	reviewer rating/comments go here
	Does the problem statement accurately describe project purpose?	Yes
	Is the problem statement professional? Think of prospective employers viewing this as part of the developer's portfolio.	Yes, it will be a CRUD project.
	What is good?	Yes
	What could be improved?	More information on game.
Design Documentation	Does it exist?	Yes
	Is the navigation/flow through the application logical and easy to use?	NA
	Is the order in which the fields are displayed and form fields entered logical and easy to use?	NA
	What data is missing?	table data
	Is there data that is not used?	no
	What is good?
	What could be improved?
Data model	Does it exist?
	Is everything on the screens represented in the model?	yes
	Does the model represent good database design?	yes
	What is good?	databases are connected
	What could be better?	More information
Additional design documents
Application structure in IntelliJ	Does it exist?	Yes
	Is the structure correct for a Maven project?	No
	Are packages and classs appropriately named?	Yes
	Other comments/notes?
JSPs	Do they exist?	Yes
	Is templating used (for example, header.jsp, footer.jsp, etc.)?	no
	Is there business logic mixed in the JSPs?
	CSS?	yes
	Other comments/notes?
Entities/DAOs/Controllers	Do they exist?	no
Java code quality	Are methods single-purpose?	na
	Are classes appropriately-sized classes (no monster classes)?	na
	Are the same lines of code repeated at all?	na
	Do any classes perform very similar functions that could be candidates for super/subclass relationships?	na
	Are any values hard-coded that should be in a properties file?	na
	Are variable names descriptive?	na
	Are there many branches or loops that could be simplified or broken up into smaller methods?	na
	Do the DAOs use Hibernate? No hard-coded sql!	na
	Other comments/notes?
Logging	Has log4J been added?	no
	Are there logging statements in the code?	no
	Are appropriate logging levels used? Info, debug, error, for example.	no
	Are there any System.out.printlns in the code?	no
	Other comments/notes?
Unit Tests	Do they exist?	no
	Do the tests pass?	na
	What is the current code coverage?	na
	Is each test truly a unit test or are they functional tests?	na
	Other comments/notes?
Web Service/API integration	Has a web service/api been selected?	yes, google authentication
	What web services/apis might work well with this application?	twitch
Independent research topic	Has a topic been selected?	yes
	What topic/s might fit well in this application?	yes

[pawaitemadisoncollege]

Can you please fix the formatting so this renders as a prettyish table? Adding a space between the || on the left hand side of each row should do it.