Show index table link - Githubissues

vvalentin-lucca commented 4 months ago

Description

Users have expressed the need to be able to open links in tables to new tabs (via the right-click menu, for example). To do this, these links must not be hidden and must be visible in the interface.

.indexTable-body-row-cell-action is therefore deprecated and replaced by .indexTable-body-row-cell-link, which is its unmasked equivalent, and following @BertrandPodevin's idea, we extend this link so that it can be operated on the whole line, without requiring an overflow: hidden, z-index, or superimposing itself on other interactive elements.

Capture d’écran 2024-06-04 à 12 04 23

LuccaIntegration commented 4 months ago

:woman_cook: https://lucca-front.lucca.tech/PR-2838/storybook

CCNET-iLucca commented 4 months ago

Tests d'interfaces

BertrandPodevin commented 4 months ago

I find this change somewhat weird because

the right click will only work if the user interact exatly on the column containing the link but, without any visual indicator he has no way to know wich one it is or even that he can do it.
for screen reader, the link content won't make sense. ex <a>Daniel Hernandez</a> or <a>CP 2023 / 2024</a>

I think that for it to realy works, we should embed the content of every column into a link and find a way to provide some context to screen reader, like "show details", while also preventing redundancy and tab hell.

vvalentin-lucca commented 4 months ago

@BertrandPodevin I agree with you.

We think it's a better solution than the completely hidden version of the link, but it's still not perfect. We thought of putting several links in each column, with a tabindex="-1" and a role="presentation", but it makes the code very heavy.

BertrandPodevin commented 4 months ago

Maybe a role="link" directly on the tr + some javascript magic could do the trick ?

https://developer.mozilla.org/fr/docs/Web/Accessibility/ARIA/Roles/link_role

vvalentin-lucca commented 4 months ago

No, it overwrites the row role of the tr and the table row disappears from the restitution.

fbasmaison-lucca commented 4 months ago

Even though lines are supposed to be clickable since we are on Index Tables, some are not yet implemented with a link and moving to a cursor: auto can actually reduce the feeling of being deceived by the interface, cursor: pointer being forced at the moment.

Would changing the pointer to only the parts that are really clickable help for discovery?

Clicking anywhere on the row could still open as expected by us, but the UI feedback would actually reflect the semantic of the elements being hovered.

LuccaIntegration commented 4 months ago

:woman_cook: https://lucca-front.lucca.tech/PR-2838/storybook

CCNET-iLucca commented 4 months ago

Tests d'interfaces

LuccaIntegration commented 4 months ago

:woman_cook: https://lucca-front.lucca.tech/PR-2838/storybook

CCNET-iLucca commented 4 months ago

Tests d'interfaces

LuccaIntegration commented 2 months ago

:woman_cook: https://lucca-front.lucca.tech/PR-2838/storybook

CCNET-iLucca commented 2 months ago

Tests d'interfaces