search

LuccaSA / lucca-front

documentation
https://prisme.lucca.io
MIT License
40 stars 4 forks source link

[User tile] Fix component height without user info #3220

Closed jeremie-lucca closed 1 week ago

jeremie-lucca commented 1 week ago

Description

Apply avatar height calculation only if it has user info (to avoid component extra height)

image

LuccaIntegration commented 1 week ago

:woman_cook: https://lucca-front.lucca.tech/PR-3220/storybook

BertrandPodevin commented 1 week ago

There seems to be a problem in the associated storybook : image

The higher specificity of :has(.userTile-content-info, .user-tile-label) override avatar default size.

jeremie-lucca commented 1 week ago

@BertrandPodevin Ah, we have an issue in the size story because avatars happen to be only placeholders here. I'll fix the story.

jeremie-lucca commented 1 week ago

Should be better!

LuccaIntegration commented 1 week ago

:woman_cook: https://lucca-front.lucca.tech/PR-3220/storybook