Luch / EasyAccordion

Enhanced Easy Accordion
11 stars 8 forks source link

IE 9 Incompatibility #4

Closed sardoodledom closed 11 years ago

sardoodledom commented 11 years ago

Not really an issue, per se, more of a message.

I found that in using the accordion #3 with IE9, I had to change jquery.easyAccordion.js to make it use the .lteIE8 css class. Otherwise, it would not rotate. I can submit a patch if you'd like. I just wanted to run it by you in case I was the only one experiencing this problem. Of course, it works and renders beautifully in anything that's not produced by Microsoft.

From this: var dtTop = (dlHeight-dtWidth)/2; var dtOffset = -dtTop; if (jQuery.browser.msie && jQuery.browser.version < 9.0) { var dtTop = 0; var dtOffset = 0; } if (jQuery.browser.msie && jQuery.browser.version < 9.0){ jQuery('html').addClass('lteIE8'); // Add class lteIE8 to HTML tag for 'conditional' CSS }

To this: var dtTop = (dlHeight-dtWidth)/2; var dtOffset = -dtTop; if (jQuery.browser.msie && jQuery.browser.version < 10.0) { var dtTop = 0; var dtOffset = 0; } if (jQuery.browser.msie && jQuery.browser.version < 10.0){ jQuery('html').addClass('lteIE8'); // Add class lteIE8 to HTML tag for 'conditional' CSS }

Luch commented 11 years ago

Hello Dispano,

Tried to reconstruct the test, without success. IE9 should respond on the -ms-... entries in css. So no need for .lteIE8 css class. Are you sure IE9 was running in native mode and not in (IE8) compatibility mode? Your solutions works either way. IE9 also supports the old IE8 style.

Luch

sardoodledom commented 11 years ago

I'm using this with grails. It could be possible that it's bundling it in a weird way. I'll look into it some more. Thanks.

Dave Spano Optogenics Systems Administrator

----- Original Message -----

From: "Luch Klooster" notifications@github.com To: "Luch/EasyAccordion" EasyAccordion@noreply.github.com Cc: "Dave Spano" sysadmin@optogenics.com Sent: Wednesday, February 13, 2013 1:55:38 PM Subject: Re: [EasyAccordion] IE 9 Incompatibility (#4)

Hello Dispano, Tried to reconstruct the test, without success. IE9 should respond on the -ms-... entries in css. So no need for .lteIE8 css class. Are you sure IE9 was running in native mode and not in (IE8) compatibility mode? Your solutions works either way. IE9 also supports the old IE8 style. Luch — Reply to this email directly or view it on GitHub .