search

LucianoCirino / efficiency-nodes-comfyui

A collection of ComfyUI custom nodes. ⚠️ WARNING: This repo is no longer maintained.
https://civitai.com/models/32342
GNU General Public License v3.0
601 stars 154 forks source link

BUG: Masks not passing through Ksampler (efficient) in series, or applied to images generated in X/Y plot #109

Open EVA-x-3 opened 1 year ago

EVA-x-3 commented 1 year ago

How to recreate problem: If you are using the "Ksampler (Efficient)" in a series (sampler 1) -> (sampler 2) -> (sampler 3) etc, and pass through the latent image using the nodes, it only applies the latent mask to the first sampler. The following "Ksampler (Efficient)" nodes do not use the mask applied to the image through the "VAE Encode (For inpainting)" node.

The same behavior is seen if you are using a single Ksampler (efficient) and an X/Y plot. I tested With X being Sampler type, and Y being Scheduler and the mask applied using the "VAE Encode (For inpainting)" node is ignored in all generations.

Expected behaviour: Mask should pass through multiple "Ksampler (Efficient)" noes in series. Masks should be applied to each generation in an x/y plot.

If I'm simply doing it wrong please correct me.

LucianoCirino commented 1 year ago

I don't have much experience with how the masks work, will investigate friend.

LucianoCirino commented 1 year ago

Should be fixed with latest repo update.