LucianoCirino / efficiency-nodes-comfyui

A collection of ComfyUI custom nodes. ⚠️ WARNING: This repo is no longer maintained.
https://civitai.com/models/32342
GNU General Public License v3.0
613 stars 155 forks source link

Err use mode "Spcript" in "Ksampler (Efficient)" #119

Open pvp-by opened 1 year ago

pvp-by commented 1 year ago

When I enable script mode, the sampler does not work correctly. error below :

Error occurred when executing KSampler (Efficient):

expected str, bytes or os.PathLike object, not NoneType

File "D:\comfy\ComfyUI\execution.py", line 151, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
File "D:\comfy\ComfyUI\execution.py", line 81, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
File "D:\comfy\ComfyUI\execution.py", line 74, in map_node_over_list
results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
File "D:\comfy\ComfyUI\custom_nodes\efficiency-nodes-comfyui\efficiency_nodes.py", line 1892, in sample
print_plot_variables(X_type, Y_type, X_value, Y_value, add_noise, seed, steps, start_at_step, end_at_step,
File "D:\comfy\ComfyUI\custom_nodes\efficiency-nodes-comfyui\efficiency_nodes.py", line 1668, in print_plot_variables
ckpt_name, clip_skip, vae_name = get_checkpoint_name(X_type, Y_type, X_value, Y_value, ckpt_name, clip_skip, "ckpt", vae_name)
File "D:\comfy\ComfyUI\custom_nodes\efficiency-nodes-comfyui\efficiency_nodes.py", line 1570, in get_checkpoint_name
ckpt_name = os.path.basename(ckpt_name)
File "ntpath.py", line 242, in basename
File "ntpath.py", line 211, in split

image

PS If you need more information, please let me know what it is and I'll be sure to add it.

LucianoCirino commented 1 year ago

Looks ike a mistake on my printout function. You can probably comment out the whole line that call the get_checkpoint_name() func for now. Will fix as soon as I have time.

LucianoCirino commented 1 year ago

@pvp-by what was your XY inputs to trigger this error?

pvp-by commented 1 year ago

any data. im update today , and now no err in console or webpage.

but it works very strangely, see the picture below: using the same parameters for denoise causes different results (in console everything is ok). image

PS if need can create new issue

LucianoCirino commented 1 year ago

This issue should potentially fixed now. However my Manual XY Entry node has changed structure, so TinyTerra's node would need to get updated. You can use the inbuilt Manual XY Input Node for now.

image