LucianoCirino / efficiency-nodes-comfyui

A collection of ComfyUI custom nodes. ⚠️ WARNING: This repo is no longer maintained.
https://civitai.com/models/32342
GNU General Public License v3.0
601 stars 154 forks source link

Comparison table of many different prompts #134

Open Melaton opened 1 year ago

Melaton commented 1 year ago

In xyPlot you can write prompts separating them by ; and get comparison table. In Efficiency Nodes I can't do anything like this. Including attempts to use "XY Input: Manual XY Entry - positive Prompt S/R". Am I doing something wrong, or is this feature not yet available?

LucianoCirino commented 1 year ago

Will be available again soon yes.

Melaton commented 1 year ago

Will be available again soon yes. Thanks for your reply and your hard work.

LucianoCirino commented 1 year ago

Manual XY Entry Node has been reintroduced again. Please update to latest repo version and try again.

image

Melaton commented 1 year ago

Will be available again soon yes.

Almost everything works, but for:

  1. XY Plot on X: Positive Prompt, 4 variables
  2. XY Plot on Y: Checkpoint, 3 or more checkpoints (for 1 or 2 - everything works!; UPD: no, work only for first checkpoint). An error occurs: Error occurred when executing KSampler (Efficient): 'NoneType' object has no attribute 'decode' File "C:\ComfyUI\ComfyUI\execution.py", line 151, in recursive_execute output_data, output_ui = get_output_data(obj, input_data_all) File "C:\ComfyUI\ComfyUI\execution.py", line 81, in get_output_data return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True) File "C:\ComfyUI\ComfyUI\execution.py", line 74, in map_node_over_list results.append(getattr(obj, func)(**slice_dict(input_data_all, i))) File "C:\ComfyUI\ComfyUI\custom_nodes\efficiency-nodes-comfyui\efficiency_nodes.py", line 1557, in sample process_values(model, refiner_model, add_noise, seed, steps, start_at_step, end_at_step, File "C:\ComfyUI\ComfyUI\custom_nodes\efficiency-nodes-comfyui\efficiency_nodes.py", line 1429, in process_values image = vae_decode_latent(vae, samples, vae_decode) File "C:\ComfyUI\ComfyUI\custom_nodes\efficiency-nodes-comfyui\efficiency_nodes.py", line 528, in vae_decode_latent return VAEDecodeTiled().decode(vae,samples,512)[0] if "tiled" in vae_decode else VAEDecode().decode(vae,samples)[0] File "C:\ComfyUI\ComfyUI\nodes.py", line 242, in decode return (vae.decode(samples["samples"]), )

XY Plot Script Inputs: (Y) Checkpoint: ('OrangeMixs_3.safetensors', None, None) ('MeinaMix.safetensors', None, None) ('photon.safetensors', None, None) ('dreamlike.safetensors', None, None)

For CkptNames+ClipSkip+VAE also same error.

LucianoCirino commented 1 year ago

Workflow please?

Melaton commented 1 year ago

Workflow please? 1

Error occurred when executing KSampler (Efficient):

'NoneType' object has no attribute 'decode' File "C:\ComfyUI\ComfyUI\execution.py", line 151, in recursive_execute output_data, output_ui = get_output_data(obj, input_data_all) File "C:\ComfyUI\ComfyUI\execution.py", line 81, in get_output_data return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True) File "C:\ComfyUI\ComfyUI\execution.py", line 74, in map_node_over_list results.append(getattr(obj, func)(**slice_dict(input_data_all, i))) File "C:\ComfyUI\ComfyUI\custom_nodes\efficiency-nodes-comfyui\efficiency_nodes.py", line 1557, in sample process_values(model, refiner_model, add_noise, seed, steps, start_at_step, end_at_step, File "C:\ComfyUI\ComfyUI\custom_nodes\efficiency-nodes-comfyui\efficiency_nodes.py", line 1429, in process_values image = vae_decode_latent(vae, samples, vae_decode) File "C:\ComfyUI\ComfyUI\custom_nodes\efficiency-nodes-comfyui\efficiency_nodes.py", line 528, in vae_decode_latent return VAEDecodeTiled().decode(vae,samples,512)[0] if "tiled" in vae_decode else VAEDecode().decode(vae,samples)[0] File "C:\ComfyUI\ComfyUI\nodes.py", line 242, in decode return (vae.decode(samples["samples"]), )

LucianoCirino commented 1 year ago

Fixed -> https://github.com/LucianoCirino/efficiency-nodes-comfyui/pull/152/commits/15a19c84feb089c5d632b2a0241f0362b66327fd