search

LucianoCirino / efficiency-nodes-comfyui

A collection of ComfyUI custom nodes. ⚠️ WARNING: This repo is no longer maintained.
https://civitai.com/models/32342
GNU General Public License v3.0
594 stars 153 forks source link

BUG - prompt is being cached when nesting style prompts #153

Open CaptainGrock opened 1 year ago

CaptainGrock commented 1 year ago

See bug video, but essentially before I nest a text/style node prompt, information there is being saved, so when the prompt is nested and I provide a value in the nested node, it ignores it and only uses the prompt in the un-nested version (hard to explain)

Bug Video - https://youtu.be/V-Tgsw8B6jI (sorry would have uploaded the video but GitHub said it was too big)

CaptainGrock commented 1 year ago

See sample workflow (if you create a new prompt and un-nest the prompt, you'll see the previous prompt exists

Simple_XY_Grid.zip

LucianoCirino commented 1 year ago

I updated repo yesterday so Efficiency Node's now play nice with the Nested Nodes (https://github.com/LucianoCirino/efficiency-nodes-comfyui/commit/8ba2fe2777b05cd1bd68ef79dca7bebc087674c2). However, I don't know if I fixed your issue because the styler nodes you are using was breaking my UI. I will have to try again tonight.

CaptainGrock commented 1 year ago

Hi - I just tested and for the Mile Styler it's fine, but for the KSampler (Efficiency Nodes) - https://github.com/LucianoCirino/efficiency-nodes-comfyui it's still doing the same thing. Can you see if you can replicate/resolve? Thanks.