LucianoCirino / efficiency-nodes-comfyui

A collection of ComfyUI custom nodes. ⚠️ WARNING: This repo is no longer maintained.
https://civitai.com/models/32342
GNU General Public License v3.0
602 stars 155 forks source link

HiRes fix - upscaling missing noise? #221

Open alenknight opened 1 year ago

alenknight commented 1 year ago

in the recent versions of the HiRes fix - if i'm doing pixel upscaling, the noise and iterations seems to be gone... any info on how to bring these back?

image

LucianoCirino commented 1 year ago

Pixel upscaling does not support iterations, and the denoise setting only makes sense for latent upscaling because its basically just an img2img.

alenknight commented 1 year ago

Pixel upscaling does not support iterations, and the denoise setting only makes sense for latent upscaling because its basically just an img2img.

i see... thanks for explaining... so with pixel upscaling ... there's no way to replicate similar to how Auto1111 does txt2img upscaling with models? anything that could be done by passing this script to another script?

alenknight commented 1 year ago

ohhhh i think i get it now.... i can just pass the pixels upscale script to a SECOND efficiency KSampler and use the denoise there to upscale...... passing the latent image from the first Ksampler.... like this? \ image