search

LucianoCirino / efficiency-nodes-comfyui

A collection of ComfyUI custom nodes. ⚠️ WARNING: This repo is no longer maintained.
https://civitai.com/models/32342
GNU General Public License v3.0
601 stars 153 forks source link

How to use X/Y Plot with the SDXL 2-step workflow ? #69

Open isamarsh opened 1 year ago

isamarsh commented 1 year ago

With the 2-step workflow, you need to use 2 KSampler Adv. (Efficient) nodes. In which of the 2 should the X/Y Plot node be used ? Or in both of them at once ?

And would it be worthwhile to make a new custom SDXL KSampler that does the 2-step workflow in one node ? That would reduce a lot of spaghetti...

LucianoCirino commented 1 year ago

I have been pretty out of the loop when it comes to SDXL. I will have to investigate the flow of work for SDXL and how I might need to update my nodes to accommodate the new changes.

moon47usaco commented 1 year ago

I really want to use the xy plot with sdxl but the results are so different without the proper clip text encoders. If you make the pos/neg inputs accept CONDITIONING inputs that would help the results. Or just use the sdxl encoders locally and make a switch to use sdxl or default. As for integrating the refiner I have been giving it thought... Not sure either... =\

I think you need to be able to send each individual generation into the refiner with the same xy conditioning... ??

LucianoCirino commented 1 year ago

I am deep at work in a big SDXL update. I hope to have it done by the end of the week.

LucianoCirino commented 1 year ago

Check out latest repo updates, hopwfully this will suffice for now...