search

LucianoCirino / efficiency-nodes-comfyui

A collection of ComfyUI custom nodes. ⚠️ WARNING: This repo is no longer maintained.
https://civitai.com/models/32342
GNU General Public License v3.0
590 stars 151 forks source link

Updated pack, now Evaluate Integer node won't work #76

Closed VikingTechLLC closed 1 year ago

VikingTechLLC commented 1 year ago

Created an image2image workflow which automatically adjusts steps across multiple ksamplers using the evaluateinteger node. Everything worked great, uploaded flow to CivitAI, over 130 downloads. Tonight went to do more work on it, updated everything (been a few weeks since last doing that), and now the first evaluateinteger node in line is throwing this error. image image

VikingTechLLC commented 1 year ago

First updated via Manager extension. That broke it initially.

Then updated via git pull. Didn't resolve.

Then updated via civitai download and zip extract and replaced files. That fixed it

LucianoCirino commented 1 year ago

When ComfyUI manager installs nodes, it is grabbing the most up to date changes because it is installing straight from the Github repo. If your workflow has custom nodes from an older install version (such as my Civit files), updating them via the ComfyUI manager on an old workflow will likely cause these types of errors without some manual work involved. What you would do is install/update via ComfyUI manager, then for every node that craps out, you manually grab a new fresh version of the node from the library (example: Efficiency Nodes -> Samplers -> KSampler (Efficient)), delete the one giving errors, and reconnect the new fresh node in its place.

There are ways to have this operation automatically done but that requires work from my end I never got around to implementing.

VikingTechLLC commented 1 year ago

Ah gotcha, thanks for the explanation regarding that. I'll keep that in mind ongoing if I run into similar issues again later