search

LucidDB / luciddb

DEFUNCT: See README
https://github.com/LucidDB/luciddb
Apache License 2.0
53 stars 24 forks source link

[FRG-307] SortRel constructor should not call RelMetadataQuery.getRowCount(child) #565

Closed dynamobi-build closed 12 years ago

dynamobi-build commented 12 years ago

[reporter="jvs", created="Mon, 28 Jan 2008 22:57:47 -0500 (GMT-05:00)"] Currently, it does this:

        // save the input row count while we still have logical RelNodes
        estimatedNumRows = RelMetadataQuery.getRowCount(child);

This looks like something added as a hack for LucidDB's optimizer.

dynamobi-build commented 12 years ago

[author="zfong", created="Tue, 29 Jan 2008 08:38:39 -0500 (GMT-05:00)"] I put this in, in Eigenchange 7411. Then I made a change in Eigenchange 7496 that resulted in that estimated row count no longer being needed. But I forgot to remove the call in SortRel. Since it's no longer being used, it should be safe to remove it.

dynamobi-build commented 12 years ago

[author="zfong", created="Tue, 29 Jan 2008 10:46:09 -0500 (GMT-05:00)"] Fix checked into lcs branch in Eigenchange 10482.

dynamobi-build commented 12 years ago

[author="zfong", created="Mon, 10 Mar 2008 07:18:13 -0500 (GMT-05:00)"] Integrated into lu/dev in Eigenchange 10685.