search

LucidVR / lucidgloves

Arduino/ESP32 based DIY VR Haptic gloves. Compatible with SteamVR via OpenGloves.
MIT License
2.02k stars 259 forks source link

Servo scaling #86

Closed kskoczyk closed 1 year ago

kskoczyk commented 1 year ago

This PR adds individual servo scaling for each finger based on pot readings And a fix to servos retracting when you go out of bounds (code proposed by danwillm#8254 on Discord, forum thread: https://discord.com/channels/784543299045818420/1017766753012559973)

JohnRThomas commented 1 year ago

I had something similar: https://github.com/LucidVR/lucidgloves/pull/56 I didn't realize the PR got closed when I deleted the branch off my repository, whoops.

I ending up basing mine off the calibration data instead of hard coded values as recommended by @danwillm.

I would also recommend squashing your change into a single commit.

danwillm commented 1 year ago

Would you mind creating two separate PRs - one for the fix to the servos and the other scaling? Cheers!

kskoczyk commented 1 year ago

Hi, sorry for the delay, I'm busy now, so I will get on it this weekend. I agree with both suggestions. @JohnRThomas That is interesting, I will definitely look at how you implemented it. @danwillm Yeah, if you're okay with me creating a PR, then sure.

kskoczyk commented 1 year ago

Closing this PR to add two separate ones. https://github.com/LucidVR/lucidgloves/pull/87 https://github.com/LucidVR/lucidgloves/pull/88