search

Lucifer06 / RemoteGPIO

Remote General Purpose I/O for Venus OS devices (Cerbo GX, ...)
12 stars 3 forks source link

Thomasinaz41213 patch 1 #3

Closed drtinaz closed 10 months ago

drtinaz commented 10 months ago

removed a fileset directory that was improperly named and served no purpose, since it didn't work anyway.

added fileset for v3.13. This fileset also has .orig files so that setup helper can automatically build new filesets after an os update if an original file match is found in a previous versions fileset.

added fileset for v3.20~33

drtinaz commented 10 months ago

I'm new to pull requests so still figuring it out. I think you have to do a merge from your side after you approve it. Only someone with write privilege can merge.

Lucifer06 commented 10 months ago

I think I now managed to understand how to work with merging your branch with the main and approve the changes. I have also added few changes in uninstall and install checking. Next release will be with the big change on how to handle post installation so the default setup doesn’t break anything for anyone.

The water is always bluer on the other side of the ocean ;-)

Le 13 déc. 2023 à 16:15, thomasinaz41213 @.***> a écrit :

I'm new to pull requests so still figuring it out. I think you have to do a merge from your side after you approve it. Only someone with write privilege can merge.

— Reply to this email directly, view it on GitHub https://github.com/Lucifer06/RemoteGPIO/pull/3#issuecomment-1854109564, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACNVCP7YWYRU63Z2KWUVVOTYJHA7JAVCNFSM6AAAAABASFK4MGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJUGEYDSNJWGQ. You are receiving this because you commented.

drtinaz commented 10 months ago

I think I now managed to understand how to work with merging your branch with the main and approve the changes. I have also added few changes in uninstall and install checking. Next release will be with the big change on how to handle post installation so the default setup doesn’t break anything for anyone. … ------------------------------------------------------------------------------ The water is always bluer on the other side of the ocean ;-) Le 13 déc. 2023 à 16:15, thomasinaz41213 @.***> a écrit : I'm new to pull requests so still figuring it out. I think you have to do a merge from your side after you approve it. Only someone with write privilege can merge. — Reply to this email directly, view it on GitHub <#3 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACNVCP7YWYRU63Z2KWUVVOTYJHA7JAVCNFSM6AAAAABASFK4MGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJUGEYDSNJWGQ. You are receiving this because you commented.

When you make the changes for the new version with the setup options, are you planning on including the option to choose tcp/ip or rs485 communication? The node red flows are slightly different between the two. If the user can choose between them maybe you can include both json's in the package and name them accordingly. For example RemoteGPIO_rs485.json and RemoteGPIO_tcpip.json. I'm pretty new to github myself, but i'm happy to help anywhere that I can.

If you want to enable discussions for this repo, (it's like a forum) you can click on the settings icon, scroll down to 'discussions' and enable. It might be easier to keep track of things like questions or suggestions.

Lucifer06 commented 10 months ago

Yes that’s the plan, I want to make a menu in VenusOs for the post configuration with the choice of communication protocole and number of relai units. Then will install the correct flows accordingly

Thanks for all the help, I see the power of having multiple brain looking at the same project :-)

The water is always bluer on the other side of the ocean ;-)

Le 16 déc. 2023 à 17:47, thomasinaz41213 @.***> a écrit :

I think I now managed to understand how to work with merging your branch with the main and approve the changes. I have also added few changes in uninstall and install checking. Next release will be with the big change on how to handle post installation so the default setup doesn’t break anything for anyone. … <x-msg://4/#> ------------------------------------------------------------------------------ The water is always bluer on the other side of the ocean ;-) Le 13 déc. 2023 à 16:15, thomasinaz41213 @.***> a écrit : I'm new to pull requests so still figuring it out. I think you have to do a merge from your side after you approve it. Only someone with write privilege can merge. — Reply to this email directly, view it on GitHub <#3 (comment) https://github.com/Lucifer06/RemoteGPIO/pull/3#issuecomment-1854109564>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACNVCP7YWYRU63Z2KWUVVOTYJHA7JAVCNFSM6AAAAABASFK4MGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJUGEYDSNJWGQ. You are receiving this because you commented.

When you make the changes for the new version with the setup options, are you planning on including the option to choose tcp/ip or rs485 communication? The node red flows are slightly different between the two. If the user can choose between them maybe you can include both json's in the package and name them accordingly. For example RemoteGPIO_rs485.json and RemoteGPIO_tcpip.json. I'm pretty new to github myself, but i'm happy to help anywhere that I can.

— Reply to this email directly, view it on GitHub https://github.com/Lucifer06/RemoteGPIO/pull/3#issuecomment-1858865793, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACNVCP6WAMXGRTV2Q6M5X53YJXGCNAVCNFSM6AAAAABASFK4MGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJYHA3DKNZZGM. You are receiving this because you modified the open/close state.