search

Lucifier129 / react-lite

An implementation of React v15.x that optimizes for small script size
MIT License
1.73k stars 98 forks source link

component data on DOM node slows down #43

Closed himalayafan closed 8 years ago

himalayafan commented 8 years ago

Hi. I notice you are storing id and relevant component data on the DOM node itself. Any reason for this? It's a major slow down. Better is to create a virtual instance and transfer the instance on update. Comparing to React, that is how they do it, plus they use the owner that you are missing.

Lucifier129 commented 8 years ago

You don't know react, and also react-lite, both of them store data at real-dom.

ghost commented 8 years ago

I think I have more knowledge then you. In the first place I wouldnt developed a library like you have, full of bad things. And you have no reasont o say I don't react. On What reason you say that? Easy to search React source code, and see things for myself. A lot of things in your code that break with React.

Lucifier129 commented 8 years ago

@jonyy123 I had show you the reason above about why I said you don't know react.