search

Lucifier129 / react-lite

An implementation of React v15.x that optimizes for small script size
MIT License
1.73k stars 100 forks source link

Processing the update queue in reverse order causes bugs #94

Open thomasbyersfluent opened 7 years ago

thomasbyersfluent commented 7 years ago

The batchUpdate method processes the update queue in the wrong order which causes bugs in my app.

I am doing an update to remove a component, then the next update deletes an object that's used by the component. Doing this in reverse order means the component attempts to access an undefined object which crashes the app.

I know the source code says this is for performance reasons, but it breaks compatibility with React. If I reverse the order of the updates, my app will no longer work in development where I use React.

Please consider using shift instead of pop.

Lucifier129 commented 7 years ago

Can you add some codes to reproduce it?