search

LucjanJanowski / translator-to-suJSON

Read subjective experiment data to suJSON format.
MIT License
2 stars 1 forks source link

Tidy and non tidy dataset package #12

Closed lukedrum closed 5 years ago

lukedrum commented 5 years ago

Tidy and non-tidy file support, config file "tidy" modification, tidy dataset AGH_NTIA_14-505

slhck commented 5 years ago

Looks good to me!

lukedrum commented 5 years ago

I checked it using three datasets. Seems like it works.

slhck commented 5 years ago

@Qub3k Should I merge this or do you want to still change something? Once it is merged, the structure is in place to do some more changes on top of it.

Qub3k commented 5 years ago

I am sorry for the long delay in responding to this. If you both say the changes are good I am ok with merging this one.

slhck commented 5 years ago

Yes, please do :)

Qub3k commented 5 years ago

One more thing, we do not yet have any heuristic of detecting whether a given XLS file is tidy, right?

slhck commented 5 years ago

Thanks for merging!

No we don't. I think we'd need to simplify a few more things in the config and assume very simple input files (see the Google Doc with the spec).

I can have a look in the coming week to see what can be done there.