LucjanJanowski / translator-to-suJSON

Read subjective experiment data to suJSON format.
MIT License
2 stars 1 forks source link

move scripts and data, improve code #2

Closed slhck closed 5 years ago

slhck commented 5 years ago
slhck commented 5 years ago

@Qub3k @lukedrum Have you seen this PR? Just wanted to know if I can help with some changes to make the package easier to use in Python.

Qub3k commented 5 years ago

I am sorry for the delay. I have been working on a short paper for QoMEX last week. I will try to review this pull request today and merge it with our code.

slhck commented 5 years ago

Sure, that takes priority! :) Not meaning to rush anything (after all, I am also not sure how much time I can spend). I just wasn't sure whether you saw the PR, depending on the GitHub notifications.

Qub3k commented 5 years ago

@slhck I went through all of your changes. I really like them, thank you!

However, there have been some updates to the xls_to_suJSON.py script, which appeared after you had opened a pull request. This, of course, is because of me being too slow to accept your pull request. Let me then make a commit in this branch to incorporate those changes. Then, I will merge it with the master branch.

slhck commented 5 years ago

Sure, no worries. I knew that there were going to be conflicts due to things you were working on in the meantime. Feel free to take whatever you need from this branch!

With regard to using this tool in practice, I will follow up with having a look at #3 once you give me the ok 👌

Qub3k commented 5 years ago

This is the beauty of Git! Just as I finished updating the code in this branch, @MikolajDuda committed his changes to the SQL_to_suJSON.py script. Thus, I need slightly more time to merge this branch.

slhck commented 5 years ago

Yeah, Git doesn't mean you don't have to talk to the other developers 😛

Qub3k commented 5 years ago

@slhck It took some time 😅, but I have finally merged this branch. Now we can move on to some new things. 😊

slhck commented 5 years ago

Great, thanks for the info! :) I will then have a look at the other Python packaging stuff and propose separate PRs for that. Also, regarding converting suJSON back to CSV, I will think about this (at least for me that would be one major use case for analyzing the data). I will be on holidays, so most likely only back at this in the second half of May.

Qub3k commented 5 years ago

Have a good time during your holidays then!