search

LucjanJanowski / translator-to-suJSON

Read subjective experiment data to suJSON format.
MIT License
2 stars 1 forks source link

Improve SRC, HRC parsing #8

Closed lukedrum closed 5 years ago

lukedrum commented 5 years ago

Add ability to use translator without SRC, HRC fields in XLS data file

Qub3k commented 5 years ago

@lukedrum I cannot merge your code since src_exist and hrc_exist are not defined anywhere.

lukedrum commented 5 years ago

@Qub3k I added missing code as well as "tidy" part.

Qub3k commented 5 years ago

@lukedrum, what is the purpose of the "additional_data" field?

If this deals with some internal design goals of the AGH/NTIA 14-505 subjective test, I think we should leave this out.

slhck commented 5 years ago

Ah, I see now that this branch has a few conflicts with mine. I thought everything was merged (hence my question if I could go ahead with changes after QoMEX).

I suggest merging this onto the branch in #11 by simply importing the functions stuff and exchanging the import_xslx/import_csv code for what is in here. Only the file path handling has to be removed since I took care of that via the input_file/output_file arguments.

Qub3k commented 5 years ago

Yeah, I think merging it with #11 is the best idea. Luckily, It should be relatively straight forward.

lukedrum commented 5 years ago

All my work is copied to #12 . This pull request can be closed

@lukedrum, what is the purpose of the "additional_data" field? If this deals with some internal design goals of the AGH/NTIA 14-505 subjective test, I think we should leave this out.

It is a scratch for future use (e.g. additional subject information)