LuckFire / amoled-cord

A basically pitch black theme for Discord. Lights out, baby!
MIT License
442 stars 280 forks source link

Recent Client Update Breaks Theme #27

Closed RadNotRed closed 2 years ago

RadNotRed commented 2 years ago

hi its me again the new discord canary / development update literally broke everything image

LuckFire commented 2 years ago

I'm going to wait a bit before doing anything, just to be sure that Discord doesn't break multiple things where I have to update almost the entire theme again. Also, only canary users are affected currently, which probably isn't a majority of users. I would like to wait til these changes are out on other builds as well.

hugh-braico commented 2 years ago

I came here to see what was going on, thanks for keeping this theme maintained, it's very much appreciated.

SuperMarioROCKS commented 2 years ago

mario likes this theme

RadNotRed commented 2 years ago

I'm going to wait a bit before doing anything, just to be sure that Discord doesn't break multiple things again where I have to update almost the entire theme again. Also, only canary users are affect currently, which probably isn't a majority of users. I would like to wait til these changes are out on other builds as well.

all good! thanks!

ghost commented 2 years ago

from the Powercord Discord channel:

Many of my plugins and themes are broken Discord released an update that broke many plugins and re-rolled many class names, which broke many themes. The solution is to wait for an update from the plugin and theme devs.

amxmu commented 2 years ago

New update broke the theme on Stable and PTB too it seems

RadNotRed commented 2 years ago

works on stable for me

elijaholmos commented 2 years ago

stable is broken on my end as well

LuckFire commented 2 years ago

reeeeeee

I'll get to updating it sometime this week

LuckFire commented 2 years ago

UPDATE: I'm currently in the process of fixing it, it'll either be ready by later today or tomorrow.

RadNotRed commented 2 years ago

UPDATE: I'm currently in the process of fixing it, it'll either be ready by later today or tomorrow.

im going to try to fix some stuff in about an hour and a half, ill update if I can get it working 100%

LuckFire commented 2 years ago

im going to try to fix some stuff in about an hour and a half, ill update if I can get it working 100%

Feel free to, but I planned on changing some things (since I'm redoing the entire theme).

RadNotRed commented 2 years ago

im going to try to fix some stuff in about an hour and a half, ill update if I can get it working 100%

Feel free to, but I planned on changing some things (since I'm redoing the entire theme).

oh god well I'm excited to see the technical v3 of it

LuckFire commented 2 years ago

It'll be labeled as v3 yea, but don't expect too much to change besides minor color adjustments.

Also, all the color issues you've reported will be fixed in this version.

Poirot12345T commented 2 years ago

same issue experienced: debug info: image

RadNotRed commented 2 years ago

if you're desperate for a working amoledcord and can't wait for v3 just git clone https://github.com/RadNotRed/amoled-cord and it should work

RadNotRed commented 2 years ago

It'll be labeled as v3 yea, but don't expect too much to change besides minor color adjustments.

Also, all the color issues you've reported will be fixed in this version.

sounds good , thanks

Goodgamer78 commented 2 years ago

broken on stable release now. rip

RadNotRed commented 2 years ago

broken on stable release now. rip

wait for v3 should be done soon

JJ-VP commented 2 years ago

@LuckFire Idk how much you plan on changing in said V3 but I have updated the theme to the new classes, want me to make a PR or are you already working on it?

gamingchairnig commented 2 years ago

@LuckFire Idk how much you plan on changing in said V3 but I have updated the theme to the new classes, want me to make a PR or are you already working on it?

could u upload it thanks

JJ-VP commented 2 years ago

could u upload it thanks

I have a fork of the theme

andrewsmyname commented 2 years ago

UPDATE: I'm currently in the process of fixing it, it'll either be ready by later today or tomorrow.

Thank you very much, your work is greatly appreciated! <3

LuckFire commented 2 years ago

@LuckFire Idk how much you plan on changing in said V3 but I have updated the theme to the new classes, want me to make a PR or are you already working on it?

Appreciate it, but I'm already working on it and almost have it done. I apologize for taking so long, since this is something I do whenever I have motivation to actually do it. I'll have the stuff pushed out by today.

RadNotRed commented 2 years ago

@LuckFire Idk how much you plan on changing in said V3 but I have updated the theme to the new classes, want me to make a PR or are you already working on it?

Appreciate it, but I'm already working on it and almost have it done. I apologize for taking so long, since this is something I do whenever I have motivation to actually do it. I'll have the stuff pushed out by today.

ur good bro, take your time

LuckFire commented 2 years ago

pushed, give it a bit to update.

ninox14 commented 2 years ago

how do you install it for better_discord ? do i have to compile it myself ?

LuckFire commented 2 years ago

how do you install it for better_discord ? do i have to compile it myself ?

it should automatically just update if you have it, unless you have a version older than 2.0.0, then you can download it here

JJ-VP commented 2 years ago

😄 Looks good. Everything seems to be spot on.

amxmu commented 2 years ago

The theme colors everything properly but when I use the "Hide member list" custom CSS with the theme -- the member list when hovered over becomes transparent. image

/ Hide member list / :root { --hover-animation-speed: 0.35s; --seperator-color: var(--seperator-color); } .membersWrap-3NUR2t { min-width: unset; width: 50px; justify-content: right; } .members-3WRCEx {transition: transform var(--hover-animation-speed);} .membersWrap-3NUR2t:hover .members-3WRCEx {transform: translateX(-190px);} .membersWrap-3NUR2t .membersGroup-2eiWxl::after { content: ''; width: 30px; height: 2px; border-radius: 50px; background: unset; background-color: var(--seperator-color); position: absolute; left: -36px; top: 29px; margin-left: 0px; } .membersWrap-3NUR2t .members-3WRCEx .member-2gU6Ar { background-color: unset; margin-left: 0px; transition: margin-left var(--hover-animation-speed); } .membersWrap-3NUR2t:hover .members-3WRCEx .member-2gU6Ar {margin-left: 8px;} .membersWrap-3NUR2t:hover .membersGroup-2eiWxl {transform: translateX(-6px);} .membersWrap-3NUR2t .membersGroup-2eiWxl { cursor: default; transform: translateX(45px); transition: transform var(--hover-animation-speed); overflow: visible; }

When I turn the theme off, the custom CSS works perfectly fine.

N72826 commented 2 years ago

image image

as you can see, there are still some things that have not been changed. I appreciate you for maintaining this still, it is a must have addition. and yes I do realize that the send button is a plugin of my own, but before the update that broke everything, it also matched the theme just fine. also, I'm not sure exactly but the color of the bottom left may also be lighter than usual. image on second thought, I probably am just seeing things when it comes to that color.

elijaholmos commented 2 years ago

amazing work, thank you for continuing to maintain the theme. I only found one area that was not styled properly: image comes from the MemberCount extension

RadNotRed commented 2 years ago

thread closed. pls make your own issues instead of spamming my inbox :(

LuckFire commented 2 years ago

replying to this so you all know that i've seen these issues, and ill push something out soon to fix and adjust things

JayMehta9292 commented 2 years ago

yo @LuckFire how long will it take to fix this broken theme?

LuckFire commented 2 years ago

yo @LuckFire how long will it take to fix this broken theme?

it is quite literally fixed, redownload if it's not working still.

JayMehta9292 commented 2 years ago

yo @LuckFire how long will it take to fix this broken theme?

it is quite literally fixed, redownload if it's not working still.

thank man redownloaded it and its fixed

JayMehta9292 commented 2 years ago

@LuckFire can you add me on discord? My discord tag is Jay Mehta#9292

i have a suggestion for you if you like then add it

RadNotRed commented 2 years ago

STOP THIS THREAD IS CLOSED

LuckFire commented 2 years ago

@LuckFire can you add me on discord? My discord tag is Jay Mehta#9292

i have a suggestion for you if you like then add it

I suggest creating another issue or just dming me on Discord, my DMs are open if you're in the powercord or bd server. Im closing this now to prevent further replies.