LuckFire / amoled-cord

A basically pitch black theme for Discord. Lights out, baby!
MIT License
411 stars 286 forks source link

Fix background for SpotifyControls player #71

Closed Max-Herbold closed 5 months ago

Max-Herbold commented 5 months ago

For the SpotifyControls plugin.

Before:

image

After:

image

Not 100% on how things are compiled for your pages. Feel free to make any changes to make this work.

Max-Herbold commented 5 months ago

Actually I realize this should probably be patched on the plugin end instead. What's an appropriate class name/id to use?

LuckFire commented 5 months ago

Depending on how the plugin injects, this could just be patched on the theme overall (especially if Discord ever plans to add extra stuff to the user area). Ideally, the plugin should inject directly into .panels__58331, then it's possible to update this file to have this:

:is(.theme-dark, .theme-midnight) .sidebar_ded4b5 {
    .panels__58331 {
        background-color: var(--background-primary);
        > div {
            background-color: var(--background-primary);
        }
    }
}

As far as I know, that shouldn't conflict with anything.

EDIT: Turns out it was more than this because of how they theme the panel, had to use !important.

Max-Herbold commented 5 months ago

Ideally, the plugin should inject directly into .panels__58331,

It is! :D

image

then it's possible to update this file to have this:

:is(.theme-dark, .theme-midnight) .sidebar_ded4b5 {
    .panels__58331 {
        background-color: var(--background-primary);
        > div {
            background-color: var(--background-primary);
        }
    }
}

We should do this

EDIT: Turns out it was more than this because of how they theme the panel, had to use !important.

Actually, seems like this worked for me without !important

LuckFire commented 5 months ago

Actually, seems like this worked for me without !important

Just to be safe, I'll leave !important in due to the issue I was having with it applying.