Closed GoogleCodeExporter closed 9 years ago
Search and VectorSearcher are definitely both needed, though if you're
integrating
with SV you might connect to SV somewhere more basic than Search.java.
By basic compilation, do you mean a manual "javac *"? You're not using ant?
Yes please, we'd like the type-safety constraints.
Original comment by widd...@google.com
on 14 Apr 2010 at 5:48
Thanks for the VectorSearcher updates.
Also, here are some additional recommended type-safety addition requests:
pitt.search.semanticvectors.VectorSearcher.java:
Line 395: this.disjunctSpace = new ArrayList <float []>(); // Added <float []>
Line 443: this.disjunctVectors = new ArrayList <float []> (); // Added <float []>
Line 574: public LinkedList <SearchResult> getNearestNeighbors (int numResults) {
// Added <SearchResult>
Line 575: LinkedList<SearchResult> results = new LinkedList <SearchResult> (); //
Added 2nd <SearchResult>
Original comment by classiclightphoto@gmail.com
on 15 Apr 2010 at 12:50
Would you be willing to check in these type-safety additions directly? That
would be
great.
-Dominic
Original comment by widd...@google.com
on 15 Apr 2010 at 2:18
I think this should be done so I went ahead and did it, I hope I haven't
stepped on any toes. See r420.
There is one missing change that I haven't committed:
src-ext/qut/beagle/BeagleNGramVectors.java:getAllVectors() deserves the same
treatment on its return type. But I didn't do it because it is in src-ext, so
presumably it comes from somewhere else.
Original comment by ThomasCR...@gmail.com
on 6 Dec 2010 at 6:05
As mentioned in Comment 4, I've added all of these except for
BeagleNGramVectors.
Original comment by ThomasCR...@gmail.com
on 8 Dec 2010 at 3:19
Awesome, thanks for all you've been doing.
I wouldn't worry about treading on any toes in src-ext, please fix anything you
see fit if you have the time. Much appreciated.
Original comment by widd...@google.com
on 8 Dec 2010 at 3:38
Original issue reported on code.google.com by
classiclightphoto@gmail.com
on 14 Apr 2010 at 5:35