search

LuckyEddie47 / kstars_extensions

GNU General Public License v3.0
1 stars 0 forks source link

siril_eaa integration #1

Open knro opened 4 months ago

knro commented 4 months ago

Ok so I wanted to test this, a couple of issues:

  1. QStateMachine is required. Maybe add this to README or add the required libraries to buld this?
  2. Why can't a regular running capture sequence be used to pass frames to Siril to livestack?
LuckyEddie47 commented 4 months ago

Hi Jasem,

Thanks for testing.

  1. I did create a static-linked build all of the extensions in order to simplify distribution but then I had second thoughts as the size of the each extension was a few MB each and it felt excessive. Do you think the convenience justifies this? I'm assuming yes seeing as you raised it.
  2. It could but I chose not to. I went the preview route because a) it felt more immediate/live from the user perspective - it's a mode turned on until you stop it rather than a set number of frames - I'm not aware of a simple way to resume a live stacking session with Siril, and b) I didn't want the situation where the user had made entries in the Capture job queue and started the EAA without realising that those jobs would be consumed. Using preview let me return Capture to it's previous state on stopping the extension. What advantage would you see with using Capture jobs?

Ed

knro commented 4 months ago
  1. No need for static linking. Just perhaps build dependencies list so that users know which dependencies to install.
  2. The advantage would be the user seeing a nice livestacked image of a running sequence. In both cases, we pass the image to Siril right? So in capture module, you can Loop images or capture them in a sequence, both of these modes should work with Siril livestacking IIRC.
LuckyEddie47 commented 4 months ago
  1. Okay.
  2. I can see this becoming a larger challenge. Each job would need to start a new live stacking session as they all have independent file paths, exposures, filters, target names, etc. The job status will have to be monitored in order for the extension to respond to completion/abort/GUI actions. Loop mode is currently not accessible via DBus which is why I faked it by looping the preview. It's all doable but I think it should wait for a V2 release of the extension.