search

LuckySherry / TwitterClient_0.2

COMP3111_Phase1_Team202
0 stars 0 forks source link

Reply with empty content #22

Closed testingtl closed 11 years ago

testingtl commented 11 years ago

What steps will reproduce the problem?

  1. write something in reply box
  2. delete all written texts

What is the expected output? What do you see instead? I see I can reply, but it shouldn't

LuckySherry commented 11 years ago

After clicking on the reply button there will be a warning message showed, isn't it?

testingtl commented 11 years ago

No warning message. It shows success.

LuckySherry commented 11 years ago

upload the snapshot please.

testingtl commented 11 years ago

before reply

LuckySherry commented 11 years ago

In our client, if you reply to any tweet without any text, the client will just update a normal tweet by the user. In the twitter.com, you can see the difference between normal tweet and reply tweet. QQ 20130416204355 As the picture shows, the upper tweet didn't show the "view conversation", that means it isn't an reply.

testingtl commented 11 years ago

reply_in_twitter What I reply in your TwitterClient will show as reply in Twitter.

LuckySherry commented 11 years ago

OK， that means the twitter API actually allow such things happens because it recognized the tweet as a reply. Maybe its webpage doesn't allow reply without anything, but its API do allows. Our different result maybe because the client on my computer is a new version and fixed some bug and added some constraint.

testingtl commented 11 years ago

It is definitely a bug for your API as what you uploaded to this github is the checking for P1. No matter how you change, all the bugs we find need to be considered based on the version in April 12.

LuckySherry commented 11 years ago

“OK， that means the twitter API actually allow such things happens because it recognized the tweet as a reply. Maybe its webpage doesn't allow reply without anything, but its API do allows.” The above holds for all the version, no matter before or after the April 12th. I talk about my new version is to point out why there are two different photo. BTW, for my API? thank you for your admiration, but I think I don't have the ability to write the API, so the Twitter official API allow reply a tweet with only usermention. If the API doesn't allow such kind of action, the client will certainly get the message. Please get more familiar with the Official API before you find bugs, LOL.

waitingcheung commented 11 years ago

Rejected. This works in mobile version.

Ken