LuckyTurtleDev / crab-hole

🦀 Pi-Hole clone written in rust using hickory-dns/trust-dns

GNU Affero General Public License v3.0

34 stars 4 forks source link

default log level leaks ip querry domain now #15

Open LuckyTurtleDev opened 1 year ago

LuckyTurtleDev commented 1 year ago

Todo:

[ ] wait for reaction at https://github.com/bluejekyll/trust-dns/issues/2014 first

LuckyTurtleDev commented 1 year ago

https://github.com/hickory-dns/hickory-dns/issues/2014 does not make much progress. So I think it would be the best to impl our own filtering for now. The best think should be to match the private data with a regex and replace them, with a placeholder.

LuckyTurtleDev commented 1 year ago

23 has fix large parts of this issue. But toplevel domains like `fritzbox.` will still be looked since matching by a regex would cause to main false positives. Lucky query toplevel domains is not very common. However this no guarantee that all private in all edge-cases is not logged. A upstream solution at trust/hickory-dns is still desirable.