LuckyTurtleDev / mstickereditor

import sticker packs from telegram, to be used at the Maunium sticker picker for Matrix
Apache License 2.0
30 stars 3 forks source link

Stickers don't show up on Element desktop #28

Closed PtPhoenix closed 1 year ago

PtPhoenix commented 1 year ago

Animated stickers don't show up on github page too, but somehow work just fine on SchildiChat on Android. I previously used sticker picker to import Telegram sticker packs. After using mstickereditor I changed index.json and added other json files.

Am I doing something wrong?

LuckyTurtleDev commented 1 year ago

Have you deleted the cache of element? Sometimes the old picker is still cached.

PtPhoenix commented 1 year ago

Yeah. Didn't help. I uploaded more and a few of them showed up on github page and now everywhere it's the same. Not all of them are showing up

LuckyTurtleDev commented 1 year ago

You probably need to reload the picker after adding more sticker after adding new. maunium/stickerpicker, msrdo/docker-stickerpicker as well as LuckyTurtleDev/mstickerpicker provide a reload button at the bottom for this.

Which picker did you use at all?

PtPhoenix commented 1 year ago

I use maunium/stickerpicker widget with LuckyTurtleDev/mstickerpicker. I found the button in maunium/stickerpicker, but pressing it did nothing. Not even on github page

PtPhoenix commented 1 year ago

I'm only converting with mstickereditor and importing from Telegram. And hosting fork of stickerpicker on github pages.

LuckyTurtleDev commented 1 year ago

If I open your picker I get the folllowing error:

Uncaught (in promise) TypeError: pack.stickers[0] is undefined
    NavBarItem https://ptphoenix.github.io/stickerpicker/web/src/index.js:339
    Preact 16
    _loadPacks https://ptphoenix.github.io/stickerpicker/web/src/index.js:179
    _loadPacks https://ptphoenix.github.io/stickerpicker/web/src/index.js:157
    componentDidMount https://ptphoenix.github.io/stickerpicker/web/src/index.js:190
    Preact 4
    <anonymous> https://ptphoenix.github.io/stickerpicker/web/src/index.js:363
index.js:339:1

This is occurs at this line:

<img src=${makeThumbnailURL(pack.stickers[0].url)}
                    alt=${pack.stickers[0].body} class="visible" />

This sounds like you are using a pack with 0 stickers, which cause the maunium/stickerpicker to fail. After this error the picker stop to load the remaining packs. You should remove the pack and probably report this issue to maunium/stickerpicker.

LuckyTurtleDev commented 1 year ago

@PtPhoenix can this be closed now?

LuckyTurtleDev commented 1 year ago

@PtPhoenix video stickers are now supported. But there is a issue with some stickers #34