Lucreeper74 / Create-Metallurgy

Add-on for Create Mod, adding new metallurgy processings.
https://modrinth.com/mod/create-metallurgy
MIT License
14 stars 12 forks source link

[BUG 🐜] Coke Block mislabeled as a Steel Storage Block, causing issues with AlmostUnified #25

Closed ratemisia closed 1 month ago

ratemisia commented 1 month ago

Describe the bug A clear and concise description of what the bug is.

The createmetallurgy:coke_block is tagged #forge:storage_blocks/steel. With other mods that require tag items for steel, this means you can use a Coke Block instead of a Steel Block in crafting recipes. And with the mod AlmostUnified, this means crafting 9 Coke in a crafting table will produce a Steel Block.

To Reproduce Steps to reproduce the behavior:

  1. Enable Advanced Tooltips
  2. Hover over a Coke Block
  3. See tag #forge:storage_blocks/steel

Expected behavior I expected the Coke Block to be labeled as #forge:storage_blocks/coke or otherwise have the tag $forge:storage_blocks/steel absent. Removing this tag from the Coke Block would eliminate all undesired crafting behavior.

Screenshots If applicable, add screenshots to help explain your problem. image

Environment:

Additional context The undesired behavior isn't obvious without AlmostUnified, but would still partially appear when Metallurgy is in an environment with any recipes that take #forge:storage_blocks/steel as a tag item (as Coke Blocks would be craftable as a Block of Steel). This should be a very simple fix, as removing the tag from the Coke Block would eliminate all undesired behavior.

Lucreeper74 commented 1 month ago

Hey @ratemisia 👋 No worries, its an known issue and its has been fixed in this commit, sorry for you disappointment for now! However, thanks you very much taking the time to make an ticket that detailed. That really help me to improve Create Metallurgy. Also, as you can see, Create Metallurgy developpement is very slow for now, you can join the Discord to see the reason.