search

Lucreeper74 / Create-Metallurgy

Add-on for Create Mod, adding new metallurgy processings.
https://modrinth.com/mod/create-metallurgy
MIT License
7 stars 4 forks source link

Foundry randomly corrupts the world on a blocktick #7

Closed DaeTheDragon closed 2 weeks ago

DaeTheDragon commented 2 weeks ago

Describe the bug createmetallurgy:foundry_top causes a 'block entity being ticked' error that makes the world unplayable

To Reproduce Steps to reproduce the behavior:

  1. Build a foundry
  2. Wait for crash

Screenshot 2024-06-14_21 23 07

Environment:

below is a crash report recorded, in which I create a superflat world, then built a foundry as shown in the image above, and after just a few minuites, the game crashes ( at 21:42:21 ) and the world is no longer acessable as the game crashes instantly upon loading it again.

Crash Report

Lucreeper74 commented 2 weeks ago

Hey @DaeTheDragon ! Sorry for your disappointing, this is a know issue, it will be fixed and push tomorrow i think. In the next update, all world with this error when join world will disapear and normally, you will be able to get back your world.

Thanks to improve Create Metallurgy by taking the time to report issues!

Lucreeper74 commented 2 weeks ago

Just a comment on your foundry build: There is two build to use Create Metallurgy for now. First, you will need a Foundry with only Blaze burner on top a Foundry Basin and on top again a Foundry Lid The second is the same setup and replace the foundry lid by a Glassed Foundry Lid and a Foundry Mixer on top.

It will not work with you use a Foundry Lid with a Foundry Mixer that two setup independently.

DaeTheDragon commented 2 weeks ago

Hey @DaeTheDragon ! This is a know issue, it will be fixed and push tomorrow i think. In the next update, all world with this error when join world will disapear and normally, you will be able to get back your world.

great! glad to hear it, thanks

Just a comment on your foundry build: There is two build to use Create Metallurgy for now. First, you will need a Foundry with only Blaze burner on top a Foundry Basin and on top again a Foundry Lid The second is the same setup and replace the foundry lid by a Glassed Foundry Lid and a Foundry Mixer on top.

It will not work with you use a Foundry Lid with a Foundry Mixer that two setup independently.

ah okay, thanks for the info there <3

Lucreeper74 commented 2 weeks ago

Alright, if you have any others questions, you can join Create Metallurgy Discord here

This issue will be close once the commit that fix it be pushed to warn others peoples.

Lucreeper74 commented 2 weeks ago

Hi again @DaeTheDragon! The bug was found, a simple error on my part. However, I would like to optimize the part of the code that manages this and I tried to reproduce the bug to evaluate the performance used by this part but without success. Could you give me the save of the world please?

DaeTheDragon commented 2 weeks ago

Sure! I used the same world to test the 1.19.2 version to confirm the bug was present there too before making the report, hopefully, that's okay! if not it only ever seems to take between two and ten minutes before the world corrupts in either version after building the foundry so I can make another easily

Here's the world in an archive!

Lucreeper74 commented 2 weeks ago

Thanks to you, now I understood how stupid I was LMAO. To put it simply, I thought the error was quite deep in the way Minecraft worked and so I needed to think more about it to avoid performance issues if I did it wrong. In fact, thanks to your backup I was able to reproduce the crash in my debugger which allows me to check the exact behavior of my code in real time. All this to realize that I had forgotten when displaying the temperature on the gauge, a rarely used intermediate state of the Blaze Burner and which therefore only occurred in a very specific situation.

This as been fixed due to a single line in this commit

Your world will be accessible after updating Create Metallurgy

Lucreeper74 commented 2 weeks ago

Sure! I used the same world to test the 1.19.2 version to confirm the bug was present there too before making the report, hopefully, that's okay! if not it only ever seems to take between two and ten minutes before the world corrupts in either version after building the foundry so I can make another easily

Here's the world in an archive!

However, funny worldsave preview image ^^

DaeTheDragon commented 2 weeks ago

Thanks so much, I'm glad it was an easy fix ^.=.^