Adding S3 Compatible Storage Support and Changing "timeout" to "frequency"

Lucretius / vault_raft_snapshot_agent

⛔️ DEPRECATED ⛔️ An agent which provides periodic snapshotting capabilities of Vault's Raft backend

MIT License

78 stars 42 forks source link

Adding S3 Compatible Storage Support and Changing "timeout" to "frequency" #2

Closed nehrman closed 3 years ago

nehrman commented 3 years ago

Hi, So I recreated a PR without the binary and with the last changes I made about timeout. My customer asked to change this as this was not very clear to him and he prefers to have "frequency" instead.

Lucretius commented 3 years ago

In general I probably won't want to rename properties based on a particular individuals desires because it would lead to a lot of churn for any existing users of the application - but in this particular case, I think renaming timeout to frequency (or interval or something like that) makes sense. I'll see if I can get this merged in today.

Lucretius commented 3 years ago

@nehrman Are you able to run the Go formatter on your PR? It looks like the frequency property change is off-shifted in config.go

Lucretius commented 3 years ago

Thank you for the PR. I've gone and merged it, and built a new release (v0.1.0) for you to use.