Lucs1590 / Personal_Site

🌐 💻 Lucas Brito personal website.
https://lucasbrito.com.br
MIT License
0 stars 0 forks source link

Add Hobbies #40

Open Lucs1590 opened 3 years ago

Lucs1590 commented 3 years ago

Create a page focused on my hobbies, so that this page contains information about books that I have already read and that I am currently reading. Additionally, use a section for sports, so that I can consume Strava data and make my annual sports goals and weekly progress visible. Finally, make a setup section, demonstrating what items and gadgets I currently have in my computer setup. Do this by maintaining the standard user interface that we use on the site, with bootstrap, and so that it looks professional, within a landing page, also adding this hobbies section in the navbar.

Checklist - [X] Create `src/app/secondary-components/hobbies/hobbies.component.ts` ✓ https://github.com/Lucs1590/Personal_Site/commit/19e1e72bf33be289dea9da318e5ef26de9a6f847 [Edit](https://github.com/Lucs1590/Personal_Site/edit/sweep/add_hobbies/src/app/secondary-components/hobbies/hobbies.component.ts) - [X] Running GitHub Actions for `src/app/secondary-components/hobbies/hobbies.component.ts` ✓ [Edit](https://github.com/Lucs1590/Personal_Site/edit/sweep/add_hobbies/src/app/secondary-components/hobbies/hobbies.component.ts) - [X] Modify `src/assets/i18n/en.json` ✓ https://github.com/Lucs1590/Personal_Site/commit/c0c1853ef0a76a23f72767d2001cda2d33861b68 [Edit](https://github.com/Lucs1590/Personal_Site/edit/sweep/add_hobbies/src/assets/i18n/en.json) - [X] Running GitHub Actions for `src/assets/i18n/en.json` ✓ [Edit](https://github.com/Lucs1590/Personal_Site/edit/sweep/add_hobbies/src/assets/i18n/en.json) - [X] Modify `src/app/secondary-components/navbar/navbar.component.ts` ✓ https://github.com/Lucs1590/Personal_Site/commit/c2b3393443b8b2ecc9d1e582a01565b0db4084c4 [Edit](https://github.com/Lucs1590/Personal_Site/edit/sweep/add_hobbies/src/app/secondary-components/navbar/navbar.component.ts) - [X] Running GitHub Actions for `src/app/secondary-components/navbar/navbar.component.ts` ✓ [Edit](https://github.com/Lucs1590/Personal_Site/edit/sweep/add_hobbies/src/app/secondary-components/navbar/navbar.component.ts) - [X] Modify `src/app/app-routing.module.ts` ✓ https://github.com/Lucs1590/Personal_Site/commit/b490bbbb30e851da3d9135328a19c3e30fedca2d [Edit](https://github.com/Lucs1590/Personal_Site/edit/sweep/add_hobbies/src/app/app-routing.module.ts) - [X] Running GitHub Actions for `src/app/app-routing.module.ts` ✓ [Edit](https://github.com/Lucs1590/Personal_Site/edit/sweep/add_hobbies/src/app/app-routing.module.ts) - [X] Create `src/app/services/strava.service.ts` ✓ https://github.com/Lucs1590/Personal_Site/commit/c504f4cf991b8c7ffadc730a6f24143ebca3bfab [Edit](https://github.com/Lucs1590/Personal_Site/edit/sweep/add_hobbies/src/app/services/strava.service.ts) - [X] Running GitHub Actions for `src/app/services/strava.service.ts` ✓ [Edit](https://github.com/Lucs1590/Personal_Site/edit/sweep/add_hobbies/src/app/services/strava.service.ts)
sweep-ai[bot] commented 8 months ago

🚀 Here's the PR! #198

See Sweep's progress at the progress dashboard!
💎 Sweep Pro: I'm using GPT-4. You have unlimited GPT-4 tickets. (tracking ID: 01a0e9cadf)

[!TIP] I can email you next time I complete a pull request if you set up your email here!


Actions (click)


Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I think are relevant in decreasing order of relevance (click to expand). If some file is missing from here, you can mention the path in the ticket description. https://github.com/Lucs1590/Personal_Site/blob/104d27e076ec9c91c79ac91eaa064f26fe959be7/src/app/secondary-components/navbar/navbar.component.ts#L1-L66 https://github.com/Lucs1590/Personal_Site/blob/104d27e076ec9c91c79ac91eaa064f26fe959be7/src/assets/i18n/en.json#L1-L21 https://github.com/Lucs1590/Personal_Site/blob/104d27e076ec9c91c79ac91eaa064f26fe959be7/src/app/app.module.ts#L1-L107

Step 2: ⌨️ Coding

Ran GitHub Actions for 19e1e72bf33be289dea9da318e5ef26de9a6f847:
• Vercel Preview Comments:

--- 
+++ 
@@ -19,5 +19,13 @@
     "publi.blog-not-found": "No blog posts matched your search criteria.",
     "publi.sci-not-found": "No scientific publications matched your search criteria.",
     "publi.tip": "Tip: If you can't find a specific text, try adding \"?search=tag\" after /publication in the URL.",
-    "recommendations.title": "Recommendations"
+    "recommendations.title": "Recommendations",
+    "hobbies.title": "Hobbies",
+    "hobbies.description": "A glimpse into the activities that fuel my creativity and keep me energized.",
+    "hobbies.booklist.title": "Booklist",
+    "hobbies.booklist.description": "A collection of books that have influenced my thinking and broadened my perspectives.",
+    "hobbies.sports.title": "Sports",
+    "hobbies.sports.description": "Tracking my annual sports goals and weekly progress with data from Strava.",
+    "hobbies.setup.title": "Setup",
+    "hobbies.setup.description": "The gadgets and gear that power my digital life and productivity."
 }

Ran GitHub Actions for c0c1853ef0a76a23f72767d2001cda2d33861b68:
• Vercel Preview Comments:

--- 
+++ 
@@ -50,6 +50,12 @@
         mobile: false,
         desktop: false
       },
+      {
+        name: firstValueFrom(this.translate.get('nav.hobbies')),
+        ref: ['/hobbies'],
+        mobile: true,
+        desktop: true
+      },
     ];
   }

Ran GitHub Actions for c2b3393443b8b2ecc9d1e582a01565b0db4084c4:
• Vercel Preview Comments:

--- 
+++ 
@@ -2,6 +2,7 @@
 import { Routes, RouterModule } from '@angular/router';
 import { NotFoundComponent } from './secondary-components/not-found/not-found.component';
 import { PublicationsComponent } from './secondary-components/publications/publications.component';
+import { HobbiesComponent } from './secondary-components/hobbies/hobbies.component';
 import { PortfolioComponent } from './portfolio/portfolio.component';
 import { SeparadorComponent } from './separador/separador.component';

@@ -10,6 +11,7 @@
   { path: 'home', component: SeparadorComponent, title: 'Lucas Brito - Personal Website' },
   { path: 'publications', component: PublicationsComponent, title: 'Lucas Brito - Publications' },
   { path: 'portfolio', component: PortfolioComponent, title: 'Lucas Brito - Portfolio' },
+  { path: 'hobbies', component: HobbiesComponent },
   { path: '404', component: NotFoundComponent, title: '404 - Not Found' },
   { path: '**', redirectTo: '404', pathMatch: 'full', title: '404 - Not Found' }
 ];

Ran GitHub Actions for b490bbbb30e851da3d9135328a19c3e30fedca2d:
• Vercel Preview Comments:

Ran GitHub Actions for c504f4cf991b8c7ffadc730a6f24143ebca3bfab:
• Vercel Preview Comments:


Step 3: 🔁 Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/add_hobbies.


🎉 Latest improvements to Sweep:
  • New dashboard launched for real-time tracking of Sweep issues, covering all stages from search to coding.
  • Integration of OpenAI's latest Assistant API for more efficient and reliable code planning and editing, improving speed by 3x.
  • Use the GitHub issues extension for creating Sweep issues directly from your editor.

💡 To recreate the pull request edit the issue title or description. Something wrong? Let us know.

This is an automated message generated by Sweep AI.