search

Luctia / ezarr

Ezarr aims to make it as easy as possible to setup an entire Servarr/Jackett/BitTorrent/Usenet/PleX/Jellyfin mediacenter stack using Docker
MIT License
730 stars 81 forks source link

Don't let people do a multi user install into their /home/user folder #41

Open fryfrog opened 10 months ago

fryfrog commented 10 months ago

Hi,

I do a lot of support for sonarr, radarr and all the many applications in one of these stacks. We're starting to have people show up on Discord having used your script to get going. But they're often storing their media and their docker configs in their ~/, but trying to do a multi user setup.

Can you fix this? The route I would go is if they choose a folder in their home folder, do a one user setup. If they pick a folder not in their home folder, like /docker for configs and /media for downloads and library do multi user. Or you could only allow multi user and block using /home.

Also, it feels like you're using UID in the 13000 range to try and avoid collisions. Why not just use the system's built in useradd and groupadd, then get those IDs to use?

Luctia commented 4 months ago

This is now partially addressed by #50, but it's not necessarily impossible to do this (yet) (although it is now very much discouraged in the README).

As for your last question, by the way, I use static IDs because, if you choose the "static" route, with the shell script and the docker-compose.yml file as it is, they need some kind of pre-set IDs. On top of that, by using these IDs, it's more clear in my opinion that they belong together (13000 is the group and everything in 13000-14000 range is ezarr users). It could potentially lead to collisions, but I think that if you're having collisions with IDs that high you already have enough experience to change the IDs in the scripts yourself.