LudiusMaximus / Immersion_ExtraFade

Improves fading out while talking to NPCs.
MIT License
0 stars 0 forks source link

Request: Add option to close bags on Immersion #7

Open Knaledge opened 1 year ago

Knaledge commented 1 year ago

When using Immersion, having my bags open ahead of interacting with an NPC/etc. that triggers Immersion will result in my bags being invisible - but still clickable, thus blocking any intent in the Immersion presentation layer.

A simple toggle in config to auto-close bags would be appreciated and be considered as a quality-of-life improvement with Immersion/Immersion Extra Fade

LudiusMaximus commented 1 year ago

Hi, I had that initially. But what I relised was that hiding the bag frame makes the game actually close the bag. Re-opening the bag (which the addon would have to do before fading the UI back in) always comes with noticable FPS drop. Its the more extreme the more bag addons you have installed (in my case bagnon with 2-3 other addons putting certain overlays over the item icons). As I use DynamicCam to automatically change the camera angle when during NPC interaction, this FPS drop was really annoying. So I resorted to just hiding the tootips of the just faded-out bag items.

But for people who are willing to accept this FPS drop, I could make it optional.

Knaledge commented 1 year ago

@LudiusMaximus - First, thank you for the consideration! Second, if you're open to it, would the following be an acceptable middle-ground?

An option to close bags on trigger of Immersion - and also a sub-option to re-open bags upon termination of Immersion.

I'll admit that I originally intended this suggestion to potentially result in a simple closing of the bags - but I had not considered the use case of users also wanting the bag to re-open. Thanks for thinking of that!

For what it's worth (and at least for me), as MVPs go I'm totally happy with the bags simply closing upon trigger of Immersion. 9/10 they are only open ahead of/during Immersion by mistake/forgetfulness. Having an option to close them (and, per your own suggestion, optionally re-opening them) would be great.