search

LudoPinelli / comment-box.nvim

:sparkles: Clarify and beautify your comments and plain text files using boxes and lines.
MIT License
408 stars 15 forks source link

Not working for `.zshrc` #41

Closed edwardbaeg closed 8 months ago

edwardbaeg commented 8 months ago

The plugin does not insert as comments in .zshrc files.

Before:

test

After CBccbox:

           ╭───────────────────────────────────────────────────────────╮
           │                           test                            │
           ╰───────────────────────────────────────────────────────────╯

Expected:

#          ╭───────────────────────────────────────────────────────────╮
#          │                           test                            │
#          ╰───────────────────────────────────────────────────────────╯
LudoPinelli commented 8 months ago

Added, thank you!

edwardbaeg commented 8 months ago

Thanks for the quick fix!

However, I am still having the issue. I have updated the plugin. If I run set filetype? I get zsh and so I would have expected your changes to have worked.

edwardbaeg commented 8 months ago

Actually, I had to remove comment_style = "auto" for this to work with box comments. If I understand this configuration setting, I would have expected the auto style to have worked properly in using line style comments for zsh as there isn't a block style available.

LudoPinelli commented 8 months ago

Actually, I had to remove comment_style = "auto" for this to work with box comments. If I understand this configuration setting, I would have expected the auto style to have worked properly in using line style comments for zsh as there isn't a block style available.

Well, it's a bug, it should work as you expected! I will look into it, thank you for letting me know!

LudoPinelli commented 8 months ago

Fixed, thanks again :)