search

Ludomancer / firefox-open-tabs-next-to-current-plus

Open all new tabs always to the right of the current one. This doesn't include tabs that are being restored or opened by New Tab Button.
MIT License
1 stars 2 forks source link

How are you defining "new tab" for this extension? #5

Closed Gitoffthelawn closed 8 years ago

Gitoffthelawn commented 9 years ago

The description of the extension states: "Opens all new tabs always next to the current tab except when a new tab is created either by new tab button or hotkey".

Is it supposed to affect all tabs that are opened from links in existing tabs or only "new tabs" (those that are typically created by pressing the new tab button or hotkey, also known as about:newtab)?

The extension affects all tabs... not sure if this is by design or an error. I'm starting to think it is by design, and I misunderstood the use of "new tab" in the description to be equivalent to "about:newtab" (which is what I actually want)!

If it's by design, would be interested in writing a small extension that just creates new tabs to the right of the current tab when Ctrl+T is pressed?

Ludomancer commented 8 years ago

The addon does the following;

So probably answer to your question is yes, it is by design. I will note that idea of yours, but can't promise anything since I currently have a very busy schedule. Let me know if that answers your question, if so I will close this ticket.

Thanks for taking the time to write!

@Gitoffthelawn

Gitoffthelawn commented 8 years ago

Thanks for the details.

To clarify, every time you used "new tab" in your response, you are referring to the about:newtab page, correct?

If you will, let me know.

If so, I think there is a bug or a conflict. The extension seems to affect all tabs, not just about:newtab tabs. Since you are busy, let's leave this open for now until we both have time to work on it. But if you let me know the answer to the above question, that will help!

Ludomancer commented 8 years ago

@Gitoffthelawn Extension affects whenever you open new tab. It doesn't matter which URL it has. There is no distinction made if it is about:newtab or not. It is by design.

Gitoffthelawn commented 8 years ago

Thanks. I think we are conveying the same thing, but using different words. ;)

When you right-click on a link and select 'Open Link in New Tab', is the extension supposed to consider that a new tab?

Ludomancer commented 8 years ago

Yes. Any kind of new tab is considered a new tab. On 23 Sep 2015 11:16, "Gitoffthelawn" notifications@github.com wrote:

Thanks. I think we are conveying the same thing, but using different words. ;)

When you right-click on a link and select 'Open Link in New Tab', is the extension supposed to consider that a new tab?

— Reply to this email directly or view it on GitHub https://github.com/Nidre/firefox-open-tabs-next-to-current-plus/issues/5#issuecomment-142556352 .

Gitoffthelawn commented 8 years ago

Thanks. That explains quite a bit!

It's not what I want, but that's okay... it's your extension and works well for your design... and I have total respect for that.

What I was looking for was an extension that only applied the functionality to 'new tabs', using the other definition of new tabs: tabs that Firefox classifies as about:newtab. IOW, when I right -click on a link and select 'Open Link in New Tab', I don't want it to apply, because that's not an about:newtab. However, if I press Ctrl+T, I want it to apply because that's an about:newtab.

The term 'new tab' is ambiguous, as it is used to mean two different things. In the case of your extension, I thought that term was using one definition, but it was using the other.

If you add an option to accommodate this use, that would be great, but since the extension is working as it was designed, I understand completely if you choose not to add this option.

If you don't add such an option, you may consider clarifying the AMO description by indicating that the functionality applies to every tab that is opened.

Either way, it's a well-written extension! :-)

Ludomancer commented 8 years ago

Glad it is clear now :) I will consider this feature, thanks for bringing it up!

Gitoffthelawn commented 8 years ago

You're welcome... and thank you. :-)