Removing platform sources for mingw under windows (building under msys2)

LudovicRousseau / pyscard

pyscard smartcard library for python

http://pyscard.sourceforge.net/

GNU Lesser General Public License v2.1

396 stars 113 forks source link

Removing platform sources for mingw under windows (building under msys2) #143

Closed kristinux closed 1 year ago

kristinux commented 1 year ago

This small changes allows to build pyscard under MSYS2/mingw environment on Windows:

python setup.py build
python setup.py install

The build process has errors, but it does complete. And the installation results in a working solution. Note: tested under mingw64 (32-bit not tested, but most likely works in the same way).

coveralls commented 1 year ago

Coverage remained the same at 23.547% when pulling 712741bb36201a863656ba9c86066ffcc66f6d6a on Enkora:build-under-msys2 into 0386e4de6fdb9dfeaf818b05f5c45d4ec4a1acfb on LudovicRousseau:master.

LudovicRousseau commented 1 year ago

I modified your code a bit in https://github.com/LudovicRousseau/pyscard-debug/commit/685055b311a325f18b7f542bee7303a01e39a9e6

Are you OK with this (untested) version?

kristinux commented 1 year ago

Sure! This should work just as well! Thank you!

Updated the PR, and tested the change under mingw64 (all ok).