search

LudovicRousseau / pyscard

pyscard smartcard library for python
http://pyscard.sourceforge.net/
GNU Lesser General Public License v2.1
377 stars 108 forks source link

Build Windows binaries also for Python 3.11 #148

Closed bittner closed 1 year ago

bittner commented 1 year ago

Makes pyscard available for Python 3.11 as a downloadable installation artifact.

coveralls commented 1 year ago

Coverage Status

Coverage: 28.576%. Remained the same when pulling 1041661e663f2e8cf9f60ccc0f8cde8d6f239a1b on bittner:feature/python3.11-windows into 430b59106f240e17e5e51b4b6a194cb20a24b743 on LudovicRousseau:master.

bittner commented 1 year ago

Seems to work fine on AppVeyor.

bittner commented 1 year ago

Looks good! Ready to merge. 🚀

LudovicRousseau commented 1 year ago

OK to add support of Python 3.11

But if the generation of MSI is disabled in recent versions of setuptools then I propose to drop the generation of MSI installers. Working with an old version of setuptools will bring issues in the future.

bittner commented 1 year ago

But if the generation of MSI is disabled in recent versions of setuptools then I propose to drop the generation of MSI installers.

I tend to agree, but I don't think it's that critical of an issue. Setuptools is so widespread and rather old versions still work; I noticed this on some older projects of mine, especially when you build packages for older Python versions.

Personally, I would suggest to let this be the last shot of building EXE installers and MSI binaries and announce that EXE and MSI's may be discontinued in future. Currently, the build process for Windows runs both on AppVeyor and on GitHub Actions; you likely want to (consolidate or) remove this anyway, some day.

Working with an old version of setuptools will bring issues in the future.

Note that the changes in this PR only ensure an older version for building the Windows EXE and MSI binaries. The artifacts that are uploaded to PyPI (and installed using pip) are not affected. (EDIT: I just noticed that's not true, but it would be easy to make it that way.)

I'm not a fan of Mircosoft Windos, but let's keep it simple for their folks, as long as we can.

LudovicRousseau commented 1 year ago

Partly merged in 874603a9d6a5bb776a941700c2269be319809e6b

bittner commented 1 year ago

Good choice to remove building the EXE installer and the MSI! 👍 (I figured using them caused the dependency problems I originally came here for. 💡)

Thanks for merging!