LudovicRousseau / pyscard

pyscard smartcard library for python
http://pyscard.sourceforge.net/
GNU Lesser General Public License v2.1
403 stars 115 forks source link

Deprecate several utility functions #188

Closed kurtmckee closed 2 months ago

kurtmckee commented 2 months ago

This PR introduces the following changes:

coveralls commented 2 months ago

Coverage Status

coverage: 43.87% (-16.2%) from 60.085% when pulling d71d968666786fcb7adb1e7c502541230c4a8ca0 on kurtmckee:utility-functions into de690e798720e0718bf128185a8cc4c56c0a7185 on LudovicRousseau:master.

LudovicRousseau commented 2 months ago

You should also update the documentation to replace calls to deprecated functions

https://github.com/LudovicRousseau/pyscard/blob/master/src/smartcard/doc/user-guide.rst#binary-strings-and-list-of-bytes

kurtmckee commented 2 months ago

Shoot, I had been filtering my search to .py files. Yep, I'll get that updated. Thanks!

kurtmckee commented 2 months ago

Hmm, that section is part of a discussion about cryptography, but specifically pycrypto, which hasn't had a release in 11 years.

I'll make a quick update to that section, but this has informed me that there's some additional work to do with that section on cryptography. :+1:

LudovicRousseau commented 2 months ago

You can update the documentation in a different commit. It will be easier to review.

kurtmckee commented 2 months ago

I included an update for SHA-1 and MD5 hashing that makes the docs for that section usable.

LudovicRousseau commented 2 months ago

Thanks