LudovicRousseau / pyscard

pyscard smartcard library for python
http://pyscard.sourceforge.net/
GNU Lesser General Public License v2.1
386 stars 111 forks source link

Fix #15 - installing from `pip` and `easy_install` (Take 2) #21

Closed ccpost closed 8 years ago

ccpost commented 8 years ago

This is much cleaner; not sure why it didn't occur to me last night. I think this should work with any install method entry point into setuptools because it's explicitly hooking into build_py, which should always be called.

The new Makefile target isn't the cleanest thing ever. I just wanted an automated way to test the whole clean installation loop into my local Python install.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 18.295% when pulling 55680b2e439f0f3a5afe0c4d693de091956c8395 on ccpost:fix/pip-install-take-two into defecae038d55cba4431c8e6ba68a843568ce1a9 on LudovicRousseau:master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 18.295% when pulling e09bc6f70262e16a04c22e6e134da5aa109d11e1 on ccpost:fix/pip-install-take-two into defecae038d55cba4431c8e6ba68a843568ce1a9 on LudovicRousseau:master.

LudovicRousseau commented 8 years ago

How is the test_install target supposed to be used? Is it only for tests on your side or should I really add it in the project?

ccpost commented 8 years ago

Up to you whether you want to include it or not. I don't imagine anyone would ever want to run it unless they were actively debugging this issue, since it does a real install into whatever Python you have active. I was just rolling up the steps I was initially doing manually to run through the different installation cases automatically.

Should I remove?

LudovicRousseau commented 8 years ago

yes, please. Remove it.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 18.295% when pulling 0f59ade5d341bbc5bd733409dd3068440eb02ecd on ccpost:fix/pip-install-take-two into defecae038d55cba4431c8e6ba68a843568ce1a9 on LudovicRousseau:master.