LudovicRousseau / pyscard

pyscard smartcard library for python
http://pyscard.sourceforge.net/
GNU Lesser General Public License v2.1
383 stars 110 forks source link

setup: support build on OpenBSD #67

Closed giovanifss closed 5 years ago

giovanifss commented 5 years ago

Hello,

I'm porting pyscard to OpenBSD and would like to contribute the patch.

This is all that is needed for pyscard to build correctly. Do you have other requirements (like documentation/INSTALL.md update)?

cc @rickard-von-essen

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 24.664% when pulling 278dc8577fc95d7553ea480673077a854e2e7b8f on giovanifss:master into db918c6955bbfae74c8b174c39597441306cc086 on LudovicRousseau:master.

LudovicRousseau commented 5 years ago

Thanks for the patch. A more flexible solution would be to just use:

platform_include_dirs = ['/usr/include/PCSC', '/usr/local/include/PCSC']

Does this proposal work for you on OpenBSD?

rickard-von-essen commented 5 years ago

Also this is not OpenBSD specific /usr/local/include/PCSC is applicable to all BSD's.

giovanifss commented 5 years ago

@LudovicRousseau Yes, I have updated! Thanks

@rickard-von-essen Cool :+1:

LudovicRousseau commented 5 years ago

Fixed in https://github.com/LudovicRousseau/pyscard/commit/f856f6ea7633ccc987cac3caac750cde78f55f43 Thanks