search

LudovicRousseau / pyscard

pyscard smartcard library for python
http://pyscard.sourceforge.net/
GNU Lesser General Public License v2.1
379 stars 108 forks source link

Updates text to be tolerant of macOS typo. #96

Closed kevingriffin closed 4 years ago

kevingriffin commented 4 years ago

This change is necessary to build on modern Macs with nix. Full details: https://github.com/NixOS/nixpkgs/issues/91716

Summary: nix-provided Python will emit an older version of macOS than the actual target when get_platform() is called. This means tests expect a misspelled error message, when in fact the system will emit the error with correct spelling.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 28.518% when pulling 4f58ac0771be2d43711227a431f6360d689bf59c on kevingriffin:macos-test-fix into ab4e79575f0be90de79bcd9193ba2609a41f137e on LudovicRousseau:master.

LudovicRousseau commented 4 years ago

Fixed in https://github.com/LudovicRousseau/pyscard/commit/945e9c4cd4036155691f6ce9706a84283206f2ef Thanks