search

Ludovicus-Maior / WoW-Pro-Guides

A World of Warcraft addon bringing guides into the game.
Other
142 stars 89 forks source link

Auto accept and sticky's #346

Closed Twists closed 1 week ago

Twists commented 13 years ago

There is an issue where the quest doesn't auto accept/turn in if there are any sticky notes above.

luis-ortiz commented 13 years ago

Oh. I have not even looked at the code and I can see the missing loop. I suspect I only look at the first active step and I probably need to iterate.

Darn.

Twists commented 12 years ago

This was actually easy to fix. In the parser, you need to change all instance of this

qidx = WoWPro.rows[1].index

to

qidx = WoWPro.rows[WoWPro.ActiveStickyCount+1].index

I've checked this out and it works great. You only concerned about the current task anyway, so this will always put it at that. If there are no stickys, then its step 0+1=1, etc....

luis-ortiz commented 12 years ago

Soo obvious in retrospect. I'll make the change for the next cut.

On Dec 25, 2011, at 4:30 PM, Twists wrote:

This was actually easy to fix. In the parser, you need to change all instance of this

qidx = WoWPro.rows[1].index

to

qidx = WoWPro.rows[WoWPro.ActiveStickyCount+1].index

I've checked this out and it works great. You only concerned about the current task anyway, so this will always put it at that. If there are no stickys, then its step 0+1=1, etc....

Reply to this email directly or view it on GitHub: https://github.com/Jiyambi/WoW-Pro-Guides/issues/346#issuecomment-3271751

Twists commented 12 years ago

Another thing I noticed is that it only compares one QID name to what the NPC offers, but doesn't take into account mulitiple QID's. So what I was thinking, and haven't tested this out, is to change item == WoWPro.step[qidx] to strfind (WoWPro.step[qidx], item) > 0. That way if I have A Quest1,Quest2,Quest3|QID|1;2;3| then if the NPC offers up Quest2, it will find it as a match.

luis-ortiz commented 12 years ago

LOL, that would do it.

On Dec 27, 2011, at 2:33 PM, Twists wrote:

Another thing I noticed is that it only compares one QID name to what the NPC offers, but doesn't take into account mulitiple QID's. So what I was thinking, and haven't tested this out, is to change item == WoWPro.step[qidx] to strfind (WoWPro.step[qidx], item) > 0. That way if I have A Quest1,Quest2,Quest3|QID|1;2;3| then if the NPC offers up Quest2, it will find it as a match.

Reply to this email directly or view it on GitHub: https://github.com/Jiyambi/WoW-Pro-Guides/issues/346#issuecomment-3284444

Twists commented 12 years ago

Ok, I see a flaw if using strfind. Mentioning the FL quests, you have a choice of two different paths to take. You do the above, you will never be able to pick and choose which one you wanted to take. I do like the thought of using this if you have a choice of 1 of a possible many quests. Perhaps have a tag that when it sees it for something like the FL's that it doesn't auto-accpet, maybe |choice|?

Twists commented 12 years ago

The above actually works well when auto-selecting a series of possible quests. The problem I am having though, it that it does not advance the step with there are multiple QID's involved. Will have to find the code that handles that part of it and make it works for muliple QID's again. As for |CHOICE|, forget that. The simplest thing to do is not put any of the quests in the quest line.

A Choose which quest you would like to do|QID|123;456|N|Choose one or the other.|

NPC box will pop open, you pick your quest, and move on. Just have to fix things to where the step actually moves on. Any clues?