LudwigBoess / GadgetIO.jl

Binary IO for the cosmological Tree-SPH code Gadget
MIT License
9 stars 1 forks source link

Fix ph keys beyond border #114

Closed lucasvalenzuela closed 10 months ago

lucasvalenzuela commented 10 months ago

For negative coordinates and coordinates beyond the box size, get_int_pos returned PH-keys offset by one. It is not clear why that is exactly (probably due to how the bits are handled, and the IDL version does it wrong, too), but the current implementation in this pull request works.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3f80035) 88.35% compared to head (402d69b) 88.37%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #114 +/- ## ========================================== + Coverage 88.35% 88.37% +0.01% ========================================== Files 30 30 Lines 1443 1445 +2 ========================================== + Hits 1275 1277 +2 Misses 168 168 ``` | [Flag](https://app.codecov.io/gh/LudwigBoess/GadgetIO.jl/pull/114/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ludwig) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/LudwigBoess/GadgetIO.jl/pull/114/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ludwig) | `88.37% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ludwig#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.