LudwigBoess / GadgetIO.jl

Binary IO for the cosmological Tree-SPH code Gadget
MIT License
9 stars 1 forks source link

Fix subfind header highword #80

Closed lucasvalenzuela closed 1 year ago

lucasvalenzuela commented 1 year ago

When reading the subfind header of Box2b, an error was previously thrown because converting Int64 to the UInt32 for the total of fof groups surpasses the limits of UInt32. The solution: change the totals to Int64.

codecov[bot] commented 1 year ago

Codecov Report

Base: 86.72% // Head: 86.72% // No change to project coverage :thumbsup:

Coverage data is based on head (5cb66f5) compared to base (ab1889c). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #80 +/- ## ======================================= Coverage 86.72% 86.72% ======================================= Files 30 30 Lines 1281 1281 ======================================= Hits 1111 1111 Misses 170 170 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `86.72% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ludwig#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/LudwigBoess/GadgetIO.jl/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ludwig) | Coverage Δ | | |---|---|---| | [src/read\_subfind/read\_header.jl](https://codecov.io/gh/LudwigBoess/GadgetIO.jl/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ludwig#diff-c3JjL3JlYWRfc3ViZmluZC9yZWFkX2hlYWRlci5qbA==) | `100.00% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ludwig). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ludwig)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.