search

LudwigBoess / SPHKernels.jl

Julia implementation of some common SPH kernels
MIT License
10 stars 0 forks source link

Simplify kernel functions #17

Closed LudwigBoess closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (roadmap_to_2_0@8d35622). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##             roadmap_to_2_0       #17   +/-   ##
==================================================
  Coverage                  ?   100.00%           
==================================================
  Files                     ?         7           
  Lines                     ?       236           
  Branches                  ?         0           
==================================================
  Hits                      ?       236           
  Misses                    ?         0           
  Partials                  ?         0
Flag Coverage Δ
unittests 100.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8d35622...9ff66df. Read the comment docs.

LudwigBoess commented 2 years ago

I can't reproduce the unicode error you see with 𝒲. For me it works fine in the Julia REPL. Can you try typing it out like it says with \scrW and then tab complete?

AhmedSalih3d commented 2 years ago

I can't reproduce the unicode error you see with 𝒲. For me it works fine in the Julia REPL. Can you try typing it out like it says with \scrW and then tab complete?

image

Seems to not work for me :)

Using Julia 1.5 with no fancy stuff, perhaps there is a error in my install.

Kind regards

LudwigBoess commented 2 years ago

Ah, maybe that's one of the new utf-8 characters they allow in 1.6. I use 1.6 and there it works fine. If it's ok for you I'll just leave it as is...

AhmedSalih3d commented 2 years ago

Ah, maybe that's one of the new utf-8 characters they allow in 1.6. I use 1.6 and there it works fine. If it's ok for you I'll just leave it as is...

Since we know the reason, totally fine - keep it as is!