search

Luegg / angularjs-scroll-glue

An AngularJs directive that automatically scrolls to the bottom of an element on changes in it's scope.
439 stars 78 forks source link

improve module name #55

Closed garretwilson closed 7 years ago

garretwilson commented 7 years ago

This is just a tiny suggestion. (I recently found out about this directive on Stack Overflow.)

I note that you are using a module name of luegg.directives, which might be appropriate if this is a whole library of Luegg's directive. But as this is just a tiny, single function module (a good thing!), maybe a model name of something like scroll-glue might be more appropriate? There are many possible variations.

Thanks for the nice work!

oliversalzburg commented 7 years ago

I completely agree with your reasoning. However, it would be a breaking change and I just don't think it's worth it, as it's not an issue that has an impact on functionality.

Usually, I would give this more consideration, but this module has been very stable for quite some time and I wouldn't want to push a major release for a semantic change like this.