Luehang / react-paypal-button-v2

An easy and simple to use React button component to implement PayPal Checkout with Smart Payment Buttons V2 (Version 2).
https://luehangs.site/lue_hang/projects/react-paypal-button-v2
MIT License
273 stars 81 forks source link

[BUG] onCancel is missing on PayPalButtonProps #79

Closed shwao closed 4 years ago

shwao commented 4 years ago

onCancel is documented here: https://github.com/Luehang/react-paypal-button-v2#large_blue_diamond-props But missing on the PayPalButtonPropsinterface.

https://github.com/Luehang/react-paypal-button-v2/blob/d819579f77723d2a361476e41e231708a6b8c01c/src/index.tsx#L101

shwao commented 4 years ago

Just found https://github.com/Luehang/react-paypal-button-v2/issues/34 which is the same issue but without the link to the code.

shwao commented 4 years ago

I should have looked in the PRs. I found this: https://github.com/Luehang/react-paypal-button-v2/pull/65 Please accept it!